Recompile wrappers because of virus warnings :-(

See #901
theotherp · Nov 27, 2023 · 6915800 · 6915800
1 parent f640aa9
commit 6915800
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 5 deletions.
diff --git a/core/src/main/resources/changelog.yaml b/core/src/main/resources/changelog.yaml
@@ -1,4 +1,10 @@
 #@formatter:off
+-   version: "v5.3.5"
+    date: "2023-11-27"
+    changes:
+      -   type: "fix"
+          text: "The compiled python wrapper exes were unfortunately flagged as a virus / malware by some antivirus engines (wrongly, of course). Unfortunately I've been unable to find a solution that results in a flawless scan. The best I can achieve right now is getting the big ones to not flag it. I'll try to report the files as false positives. Sorry for the inconvenience. See #901"
+    final: true
 -   version: "v5.3.4"
     date: "2023-11-20"
     changes:

diff --git a/other/wrapper/pyInstaller/buildWindows.cmd b/other/wrapper/pyInstaller/buildWindows.cmd
@@ -1,6 +1,7 @@
 @echo off
 call venv_py3\scripts\activate.bat
-venv_py3\scripts\pip install pystray requests pyinstaller
+rem Pyinstaller 5.13.2 results in the fewest false positives: https://www.virustotal.com/gui/file/f28f3212537af3e96a809d81e08509d168e3318bf098b09690ec7085b6d7e09f?nocache=1
+venv_py3\scripts\pip install pystray requests pyinstaller==5.13.2
 rem Make sure this is python 3.8, after that Windows 7 support is ended
 copy ..\nzbhydra2wrapperPy3.py windows
 cd windows
@@ -14,4 +15,5 @@ cd windows_console
 echo "Running pyinstaller for Windows Console"
 ..\venv_py3\Scripts\pyinstaller.exe "NzbHydra2 Console.spec"
 copy "dist\NZBHydra2 Console.exe" ..\..\..\..\releases\windows-release\include
+cd..
 echo "Finished running pyinstaller for Windows Console"
diff --git a/releases/windows-release/include/NZBHydra2 Console.exe b/releases/windows-release/include/NZBHydra2 Console.exe
diff --git a/releases/windows-release/include/NZBHydra2.exe b/releases/windows-release/include/NZBHydra2.exe