Merge pull request #227 from thibaudgg/fix_specs

Fix specs 🔧
thibaudgg · Oct 27, 2023 · 2a94d69 · 2a94d69
2 parents 5fb0edf + f417e2e
commit 2a94d69
Show file tree

Hide file tree

Showing 164 changed files with 5,413 additions and 5,332 deletions.
diff --git a/lib/video_info/providers/youtube_scraper.rb b/lib/video_info/providers/youtube_scraper.rb
@@ -29,7 +29,11 @@ def author_thumbnail
       end
 
       def channel_id
-        itemprop_node_value("channelId")
+        # NOTE the previous implementation, based on itemprop_node_value("channelId"),
+        # does not work well, probably due to some YouTube change
+        page_content = data.to_s
+        matches = page_content.match(/"channelId":"([a-zA-Z0-9_-]+)"/)
+        matches[1] if matches
       end
 
       def author_url

diff --git a/...eoInfo_Providers_Dailymotion/_available_/with_invalid_video_url/_available_/1_2_2_1_1.yml b/...eoInfo_Providers_Dailymotion/_available_/with_invalid_video_url/_available_/1_2_2_1_1.yml
diff --git a/...es/VideoInfo_Providers_Dailymotion/_available_/with_valid_video/_available_/1_2_1_1_1.yml b/...es/VideoInfo_Providers_Dailymotion/_available_/with_valid_video/_available_/1_2_1_1_1.yml
diff --git a/...tures/vcr_cassettes/VideoInfo_Providers_Dailymotion/with_video_x7lni3/_author/1_3_7_1.yml b/...tures/vcr_cassettes/VideoInfo_Providers_Dailymotion/with_video_x7lni3/_author/1_3_7_1.yml
diff --git a/...cassettes/VideoInfo_Providers_Dailymotion/with_video_x7lni3/_author_thumbnail/1_3_9_1.yml b/...cassettes/VideoInfo_Providers_Dailymotion/with_video_x7lni3/_author_thumbnail/1_3_9_1.yml
diff --git a/...s/vcr_cassettes/VideoInfo_Providers_Dailymotion/with_video_x7lni3/_author_url/1_3_8_1.yml b/...s/vcr_cassettes/VideoInfo_Providers_Dailymotion/with_video_x7lni3/_author_url/1_3_8_1.yml
diff --git a/...ttes/VideoInfo_Providers_Dailymotion/with_video_x7lni3/_date/should_show_correct_date.yml b/...ttes/VideoInfo_Providers_Dailymotion/with_video_x7lni3/_date/should_show_correct_date.yml
diff --git a/...vcr_cassettes/VideoInfo_Providers_Dailymotion/with_video_x7lni3/_description/1_3_10_1.yml b/...vcr_cassettes/VideoInfo_Providers_Dailymotion/with_video_x7lni3/_description/1_3_10_1.yml
diff --git a/...es/vcr_cassettes/VideoInfo_Providers_Dailymotion/with_video_x7lni3/_duration/1_3_12_1.yml b/...es/vcr_cassettes/VideoInfo_Providers_Dailymotion/with_video_x7lni3/_duration/1_3_12_1.yml
diff --git a/...es/vcr_cassettes/VideoInfo_Providers_Dailymotion/with_video_x7lni3/_keywords/1_3_11_1.yml b/...es/vcr_cassettes/VideoInfo_Providers_Dailymotion/with_video_x7lni3/_keywords/1_3_11_1.yml