Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

valid_url returns true with user page #223

Closed
miguelpeniche opened this issue Aug 22, 2023 · 2 comments · Fixed by #228
Closed

valid_url returns true with user page #223

miguelpeniche opened this issue Aug 22, 2023 · 2 comments · Fixed by #228
Labels

Comments

@miguelpeniche
Copy link

There is a minor bug, checking the Vimeo user page VideoInfo.valid_url? "https://vimeo.com/user123456789" is returning true.

@markets
Copy link
Collaborator

markets commented Oct 17, 2023

Hello @miguelpeniche!

This URL is checked by this method:

url.match?(/(vimeo\.com\/(?!album|hubnut\/album).*)/)

Feel free to send a patch to improve this scenario 🙌🏼 Probably just changing the regexp to (vimeo\.com\/(?!album|hubnut\/album|user\d+).*) will do the trick (NOTE added |user\d+). Demo: https://rubular.com/r/tLPWvBvMU8Ad6c

If you can't send a patch, I'll try to do it by myself in the following days.

Thanks for reporting!

@markets markets added the bug label Oct 17, 2023
Spone added a commit to Spone/video_info that referenced this issue Oct 27, 2023
@Spone
Copy link
Contributor

Spone commented Oct 27, 2023

Here is a PR for this: #228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants