Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Vimeo valid_url? for user page #228

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Fix Vimeo valid_url? for user page #228

merged 1 commit into from
Oct 27, 2023

Conversation

Spone
Copy link
Contributor

@Spone Spone commented Oct 27, 2023

Close #223

@Spone Spone mentioned this pull request Oct 27, 2023
Closed
@Spone
Copy link
Contributor Author

Spone commented Oct 27, 2023

I slightly changed the regexp you suggested @markets, so the "review" URLs still work.
See https://regexr.com/7mbd2

markets
markets approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@markets markets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 😎

@markets markets merged commit 7965964 into thibaudgg:master Oct 27, 2023
0 of 6 checks passed
@Spone Spone deleted the fix-valid-url-vimeo-user-page branch October 27, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markets markets markets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

valid_url returns true with user page
2 participants
@Spone @markets