moving to html5 #877
Open
moving to html5 #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
going responsive, It would work better with a new html5 layout
I'm not a programmer, nor I'm abl eto compile so theese mods are not tested.
Please read mi comments, they start as # AR...
These are my proposal for a more semantic (html5) output:
NAV (index button)
ARTICLE (the full recipe)
HEADER the title
FIGURE the image
ASIDE
TABLE of header elements
SECTION
TABLE of ingredients
SECTION instructions
SECTION notes
First and most important - the title is an H1 elment, not a P
moving DIVs to Html5 semantic tags
adding an "index" button that shall disappear in a one-page
head formatted as table - I wish to do it also for the ingredients but I wasn't able, sorry.
thi is companion of the new html_exporter that I proposed
Hello, this is my html5 export proposal (some bug fixed since my last committ). Please read the comments # AR... for modifications and wishes that I cuoldn't fix myself, like giving to BODY an univoque ID (maybe the filename) or how to implement the ingredients in a table instead of a list. I made also a CSS that works with this ouput, that is responsive and has also an @media PRINT statement (which doesn't work when embedded (single recipe export)). Feedback and help to improve it would be appreciated. BUG: I noticed a bug in the original plug-in wich I couldn't fix: the href of an image file comes with both forward and back slashes.
Tis is a CSS that works with my HTML5 proposed exporter. At the end there's an @media PRINT statement that only works in an exported stylesheet, not when embedded (single recipe export), so printing a single recipe is ugly. I can't fix this.
fixed small typo error
|
After updating my machine from win7/32 to win7/64 I'm not able any more to use my own modifications - for some reason when I suobstitue the 2 files I loose the ability to export to html |
|
This is a good idea. It would be nice if it was done with an (X)HTML microformat like h-recipe (v2) or hRecipe (v1). EDIT: After doing a little more investigating of the recipe web landscape, I think that using http://schema.org/Recipe is a better move to support in HTML format. It is widely deployed today. |
ranwise
reviewed
Nov 2, 2018
|
|
||
| h1, h2, h3, h4, h5, h6 { | ||
| font-weight: bold; | ||
| font-family: "georgia" serif; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello I'm new to programming and to Github, I'm just an hobbist web designer.
I wish to improve the html exporter to make it more semantic, more html5 complaint, and the relative styles, so I tryied to change the html exporter commenting my changes and my wishes. I hope that someone cuold complete my efforts.
I also propose a modified CSS, more responsive (rem based), minimal, and with a @media print that only works as a external CSS, non embedded - trying to fix this - (anyway if we change the html we shall change also the css).
Thank you for your help, patience and attention.
Proposed structure:
I managed to obtain what I wish (I'm using it actually), but it can be further improved. Please see my comments in the code - they start with a # AR...