Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update param name #534

Merged
merged 5 commits into from
Oct 12, 2023
Merged

Update param name #534

merged 5 commits into from
Oct 12, 2023

Conversation

kumaryash90
Copy link
Member

@kumaryash90 kumaryash90 commented Oct 12, 2023

Constructor API change breaks deployment of the updated MarketplaceV3 contract from SDK.

Adding a temporary measure to correctly parse struct input on SDK during deployment.

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
...prebuilts/marketplace/entrypoint/MarketplaceV3.sol 18.51% <ø> (ø)

📢 Thoughts on this report? Let us know!.

@joaquim-verges joaquim-verges merged commit 516e229 into main Oct 12, 2023
7 checks passed
@joaquim-verges joaquim-verges deleted the yash/update-param-name branch October 12, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants