Update isValidSignature replay protection #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #620 +/- ##
==========================================
- Coverage 64.73% 64.55% -0.18%
==========================================
Files 216 216
Lines 6700 6703 +3
==========================================
- Hits 4337 4327 -10
- Misses 2363 2376 +13 ☔ View full report in Codecov by Sentry. |
nkrishang
changed the title
nezz0746
pushed a commit
to nezz0746/contracts
that referenced
this pull request
Mar 4, 2024
* Don't double hash in smart wallet isValidSignature replay protection * Update _originalMessageHash -> _hash * EIP712 typed data signature for isValidSignature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.