Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do Not Merge] benchmark tokenerc721 alt #625

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

gas benchmarks for tokenerc721

1491165
Select commit
Loading
Failed to load commit list.
Draft

[Do Not Merge] benchmark tokenerc721 alt #625

gas benchmarks for tokenerc721
1491165
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / Slither succeeded Mar 11, 2024 in 19s

3 new alerts including 2 low severity security vulnerabilities

New alerts in code changed by this pull request

Security Alerts:

  • 2 low

Other Alerts:

  • 1 warning

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 108 in contracts/prebuilts/token/TokenERC721Alt.sol

See this annotation in the file changed.

Code scanning / Slither

Local variable shadowing Low

TokenERC721Alt.initialize(address,string,string,string,address[],address,uint128)._symbol shadows:
- ERC721Upgradeable._symbol (state variable)

Check notice on line 107 in contracts/prebuilts/token/TokenERC721Alt.sol

See this annotation in the file changed.

Code scanning / Slither

Local variable shadowing Low

TokenERC721Alt.initialize(address,string,string,string,address[],address,uint128)._name shadows:
- ERC721Upgradeable._name (state variable)
- EIP712Upgradeable._name (state variable)

Check warning on line 375 in contracts/prebuilts/token/TokenERC721Alt.sol

See this annotation in the file changed.

Code scanning / Slither

Missing inheritance Warning

TokenERC721Alt should inherit from IBurnableERC721