This repository has been archived by the owner on Jun 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 128
Allow uploading to IPFS without a folder (when upload a single file) #2667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kien-ngo
requested review from
jnsdls,
joaquim-verges and
MananTank
as code owners
June 14, 2024 19:59
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org requires the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Did a few rounds of test. Yash also helping |
joaquim-verges
approved these changes
Jun 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
Customer confirmed the fix. Merging |
Merge activity
You must have a Graphite account in order to use the merge queue. Create an account and try again using this link
|
…2667) <img width="819" alt="image" src="https://github.com/thirdweb-dev/dashboard/assets/26052673/205d590e-893e-4f1b-a4f0-c5aaab9bdf01"> <!-- start pr-codex --> --- ## PR-Codex overview The focus of this PR is to add a feature that allows users to choose whether to upload a file to a folder or without a folder in the IPFS uploader component. ### Detailed summary - Added a `Checkbox` component for users to choose upload options - Introduced state for tracking upload preferences - Updated UI elements based on user's upload selection > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
The focus of this PR is to add the ability for users to choose whether to upload a file to a folder when uploading a single file to IPFS.
Detailed summary
Checkbox
component for user choice