Skip to content
This repository has been archived by the owner on Jun 19, 2024. It is now read-only.

Allow uploading to IPFS without a folder (when upload a single file) #2667

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Jun 14, 2024

image

PR-Codex overview

The focus of this PR is to add the ability for users to choose whether to upload a file to a folder when uploading a single file to IPFS.

Detailed summary

  • Added a Checkbox component for user choice
  • Added logic to handle uploading to a folder based on user selection
  • Updated UI elements to reflect upload progress and user choices

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Jun 14, 2024

Copy link

vercel bot commented Jun 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2024 7:50pm

Copy link

graphite-app bot commented Jun 14, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@kien-ngo
Copy link
Contributor Author

Did a few rounds of test. Yash also helping

Copy link
Member

@joaquim-verges joaquim-verges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@kien-ngo
Copy link
Contributor Author

Customer confirmed the fix. Merging

@kien-ngo kien-ngo added the merge-queue adds this branch to the merge queue label Jun 15, 2024
Copy link

graphite-app bot commented Jun 15, 2024

Merge activity

  • Jun 15, 3:37 AM UTC: @kien-ngo we removed the merge queue label because we could not find a Graphite account associated with your GitHub profile.

You must have a Graphite account in order to use the merge queue. Create an account and try again using this link

  • Jun 17, 3:25 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jun 17, 3:39 PM EDT: kien-ngo added this pull request to the Graphite merge queue.
  • Jun 17, 3:50 PM EDT: kien-ngo merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot removed the merge-queue adds this branch to the merge queue label Jun 15, 2024
@kien-ngo kien-ngo added the merge-queue adds this branch to the merge queue label Jun 17, 2024
…2667)

<img width="819" alt="image" src="https://github.com/thirdweb-dev/dashboard/assets/26052673/205d590e-893e-4f1b-a4f0-c5aaab9bdf01">

<!-- start pr-codex -->

---

## PR-Codex overview
The focus of this PR is to add a feature that allows users to choose whether to upload a file to a folder or without a folder in the IPFS uploader component.

### Detailed summary
- Added a `Checkbox` component for users to choose upload options
- Introduced state for tracking upload preferences
- Updated UI elements based on user's upload selection

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
merge-queue adds this branch to the merge queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants