This repository has been archived by the owner on Jun 19, 2024. It is now read-only.
refactor: update Accounts components to use new contract hooks and add pagination #2669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org requires the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
MananTank
approved these changes
Jun 14, 2024
Merge activity
|
…d pagination (#2669) ### TL;DR Implement pagination and count querying in the accounts page. ### What changed? 1. Modified `accounts-count.tsx` to use `totalAccounts` from `thirdweb/extensions/erc4337` instead of fetching all accounts. 2. Updated `accounts-table.tsx` to incorporate pagination with the help of `totalAccounts` and `getAccounts` functions from `thirdweb/extensions/erc4337`. 3. Adjusted `page.tsx` to pass the contract to `AccountsCount` and `AccountsTable` components instead of accountsQuery. 4. Introduced pagination controls and page size selection in `accounts-table.tsx`. ### How to test? 1. Navigate to the accounts page. 2. Verify that the total number of accounts is displayed correctly. 3. Check the pagination functionality by navigating through pages and adjusting the page size. ### Why make this change? To improve the user experience on the accounts page by enabling efficient data fetching and display through pagination. ---
jnsdls
force-pushed
the
feat/refactor-accounts-components
branch
from
aa13b0a to
9ae2f58
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Implement pagination and count querying in the accounts page.
What changed?
accounts-count.tsxto usetotalAccountsfromthirdweb/extensions/erc4337instead of fetching all accounts.accounts-table.tsxto incorporate pagination with the help oftotalAccountsandgetAccountsfunctions fromthirdweb/extensions/erc4337.page.tsxto pass the contract toAccountsCountandAccountsTablecomponents instead of accountsQuery.accounts-table.tsx.How to test?
Why make this change?
To improve the user experience on the accounts page by enabling efficient data fetching and display through pagination.
PR-Codex overview
This PR focuses on optimizing the Accounts UI by integrating new contract functions and improving pagination.
Detailed summary