This repository has been archived by the owner on Jun 19, 2024. It is now read-only.
feat: integrate abitype library and format ABI items in code overview and contract function components #2672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org requires the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
joaquim-verges
approved these changes
Jun 15, 2024
jnsdls
force-pushed
the
feat/add-abitype-integration
branch
from
de58cfe to
32f600f
Compare
Merge activity
|
… and contract function components (#2672) ### TL;DR Add `abitype` library and refactor the codebase to utilize `formatAbiItem` for formatting contract functions and events. ### What changed? - Added `abitype` library to `package.json` and `pnpm-lock.yaml` files. - Refactored multiple files to replace existing ABI formatting logic with `formatAbiItem` from `abitype`. - `contract-function.tsx`: Integrated `formatAbiItem` for formatting contract functions and events. - `code-overview.tsx`: Unified ABI formatting using `formatAbiItem`. - Removed dependency on `resolveMethod` from `thirdweb`. ### How to test? 1. Verify the `abitype` library installation in `package.json` and `pnpm-lock.yaml`. 2. Check the refactored files for correct usage of `formatAbiItem`. 3. Run the project and ensure no runtime errors occur related to ABI formatting. 4. Test contract functions and events to ensure they are formatted correctly. ### Why make this change? To improve the consistency and reliability of ABI formatting across the codebase by using a dedicated library (`abitype`). --- <!-- start pr-codex --> --- ## PR-Codex overview The focus of this PR is to introduce the `abitype` package, update dependencies, and refactor code snippets in the `CodePlayground` component. ### Detailed summary - Introduced `abitype` package - Updated dependencies - Refactored code snippets in `CodePlayground.tsx` - Modified imports and functions in various files > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
jnsdls
force-pushed
the
feat/add-abitype-integration
branch
from
32f600f to
4faf636
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Add
abitypelibrary and refactor the codebase to utilizeformatAbiItemfor formatting contract functions and events.What changed?
abitypelibrary topackage.jsonandpnpm-lock.yamlfiles.formatAbiItemfromabitype.contract-function.tsx: IntegratedformatAbiItemfor formatting contract functions and events.code-overview.tsx: Unified ABI formatting usingformatAbiItem.resolveMethodfromthirdweb.How to test?
abitypelibrary installation inpackage.jsonandpnpm-lock.yaml.formatAbiItem.Why make this change?
To improve the consistency and reliability of ABI formatting across the codebase by using a dedicated library (
abitype).PR-Codex overview
The focus of this PR is to introduce the
abitypepackage, update dependencies, and refactor code snippets for improved readability.Detailed summary
abitypepackageCodePlayground.tsxfor better readabilitypackage.jsonandpnpm-lock.yamlformatAbiItemfunction incode-overview.tsx