This repository has been archived by the owner on Jun 19, 2024. It is now read-only.
refactor: remove unused 'lottie' prop from LandingHero component #2683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
MananTank
approved these changes
Jun 18, 2024
Merge activity
|
### TL;DR
Removed the `lottie` animation support in the `LandingHero` component.
### What changed?
- Deleted the `lottie` property from the `LandingHeroProps` interface.
- Removed `lottie` from the `LandingHero` component's destructured props.
- Deleted the `Flex` container that previously contained the `LandingDesktopMobileImage` with the `lottie` prop.
### How to test?
1. Verify that the `LandingHero` component no longer expects or handles the `lottie` prop.
2. Ensure that there are no visual or functional regressions in the `LandingHero` component on various pages where it is used.
### Why make this change?
The `lottie` animation support was deemed unnecessary and has been removed to streamline the component's implementation and reduce complexity.
---
<!-- start pr-codex -->
## PR-Codex overview
The focus of this PR is to remove the `lottie` prop from the `LandingHero` component in `hero.tsx`.
### Detailed summary
- Removed the `lottie` prop from `LandingHero` component
- Adjusted component structure to accommodate the removal
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
jnsdls
force-pushed
the
refactor/remove-unused-prop-landing-hero
branch
from
9d24914 to
1517db8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Removed the
lottieanimation support in theLandingHerocomponent.What changed?
lottieproperty from theLandingHeroPropsinterface.lottiefrom theLandingHerocomponent's destructured props.Flexcontainer that previously contained theLandingDesktopMobileImagewith thelottieprop.How to test?
LandingHerocomponent no longer expects or handles thelottieprop.LandingHerocomponent on various pages where it is used.Why make this change?
The
lottieanimation support was deemed unnecessary and has been removed to streamline the component's implementation and reduce complexity.PR-Codex overview
This PR removes the
lottieprop fromLandingHerocomponent and refactors the rendering of images.Detailed summary
lottieprop fromLandingHeroLandingHerocomponent