-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor rpc for easier reuse #88
Merged
iuwqyir
merged 1 commit into
main
from
10-04-refactor_rpc_to_a_wrapper_for_easier_reuse
Oct 10, 2024
Merged
Refactor rpc for easier reuse #88
iuwqyir
merged 1 commit into
main
from
10-04-refactor_rpc_to_a_wrapper_for_easier_reuse
Oct 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 4, 2024
iuwqyir
changed the title
refactor rpc to a wrapper for easier reuse
Refactor RPC client and improve batch processing
Oct 4, 2024
iuwqyir
changed the title
Refactor RPC client and improve batch processing
Refactor rpc for easier reuse
Oct 4, 2024
AmineAfia
reviewed
Oct 7, 2024
AmineAfia
reviewed
Oct 7, 2024
AmineAfia
reviewed
Oct 7, 2024
AmineAfia
approved these changes
Oct 7, 2024
iuwqyir
force-pushed
the
10-04-refactor_rpc_to_a_wrapper_for_easier_reuse
branch
2 times, most recently
from
October 7, 2024 20:01
8663df7
to
01aba8e
Compare
This was referenced Oct 8, 2024
iuwqyir
force-pushed
the
10-04-refactor_rpc_to_a_wrapper_for_easier_reuse
branch
from
October 10, 2024 12:48
01aba8e
to
49fe94d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Refactored RPC to wrap the needed rpc calls and return already serialized data. This way we don't have to repeat the request creation and response handling whenever we need it. We have fixed queries so maintaining wrappers doesn't seem like a problem
What changed?
common
package to a newrpc
packageClient
struct in therpc
package to handle RPC operationsHow to test?
Why make this change?
This refactoring improves the overall structure and performance of the indexer: