Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridge upgrade #173

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Bridge upgrade #173

merged 1 commit into from
Apr 9, 2024

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Apr 8, 2024

PR-Codex overview

This PR updates the thirdweb-unity-bridge.js file by refactoring and optimizing functions related to buffer manipulation.

Detailed summary

  • Refactored functions for buffer manipulation
  • Optimized code for better performance
  • Removed unnecessary variables and conditions

The following files were skipped due to too many changes: Assets/WebGLTemplates/Thirdweb/lib/thirdweb-unity-bridge.js

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

github-actions bot commented Apr 8, 2024

Test Results for Android

  1 files  ±0   15 suites  ±0   6m 10s ⏱️ -10s
 96 tests ±0   96 ✅ ±0  0 💤 ±0  0 ❌ ±0 
100 runs  ±0  100 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3c1cb58. ± Comparison against base commit aced1c7.

Copy link

github-actions bot commented Apr 8, 2024

Test Results for iOS

  1 files  ±0   15 suites  ±0   6m 24s ⏱️ -7s
 96 tests ±0   96 ✅ ±0  0 💤 ±0  0 ❌ ±0 
100 runs  ±0  100 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3c1cb58. ± Comparison against base commit aced1c7.

Copy link

github-actions bot commented Apr 9, 2024

Test Results for StandaloneLinux64

  1 files  ±0   15 suites  ±0   6m 27s ⏱️ - 1m 20s
 96 tests ±0   96 ✅ ±0  0 💤 ±0  0 ❌ ±0 
100 runs  ±0  100 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3c1cb58. ± Comparison against base commit aced1c7.

Copy link

github-actions bot commented Apr 9, 2024

Test Results for WebGL

  1 files  ±0   15 suites  ±0   6m 25s ⏱️ -2s
 96 tests ±0   96 ✅ ±0  0 💤 ±0  0 ❌ ±0 
100 runs  ±0  100 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3c1cb58. ± Comparison against base commit aced1c7.

@0xFirekeeper 0xFirekeeper merged commit b5792b9 into main Apr 9, 2024
13 checks passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/new-bridge-test branch April 9, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant