Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contract.FetchAbi Helper #174

Merged
merged 5 commits into from
Apr 10, 2024
Merged

Contract.FetchAbi Helper #174

merged 5 commits into from
Apr 10, 2024

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Apr 9, 2024

PR-Codex overview

This PR updates contract handling in Unity tests and scripts. It introduces a new method to fetch ABI and adjusts contract creation and reading accordingly.

Detailed summary

  • Added FetchAbi method to retrieve ABI from a URL
  • Updated contract creation and reading methods to use fetched ABI
  • Updated contract addresses and signer addresses in tests and scripts

The following files were skipped due to too many changes: Assets/Thirdweb/Examples/Scripts/Prefabs/Prefab_Miscellaneous.cs

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

github-actions bot commented Apr 9, 2024

Test Results for StandaloneLinux64

  1 files  ±0   15 suites  ±0   6m 46s ⏱️ -49s
 96 tests ±0   96 ✅ ±0  0 💤 ±0  0 ❌ ±0 
100 runs  ±0  100 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 080d475. ± Comparison against base commit ec4ce3e.

This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.
Custom_WithoutAbi_FailNativeSucceedWebGL
Custom_WithoutAbi_Fetch

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 9, 2024

Test Results for WebGL

  1 files  ±0   15 suites  ±0   6m 37s ⏱️ +11s
 96 tests ±0   96 ✅ ±0  0 💤 ±0  0 ❌ ±0 
100 runs  ±0  100 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 080d475. ± Comparison against base commit ec4ce3e.

This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.
Custom_WithoutAbi_FailNativeSucceedWebGL
Custom_WithoutAbi_Fetch

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 9, 2024

Test Results for Android

  1 files  ±0   15 suites  ±0   6m 43s ⏱️ - 1m 8s
 96 tests ±0   96 ✅ ±0  0 💤 ±0  0 ❌ ±0 
100 runs  ±0  100 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 080d475. ± Comparison against base commit ec4ce3e.

This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.
Custom_WithoutAbi_FailNativeSucceedWebGL
Custom_WithoutAbi_Fetch

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 9, 2024

Test Results for iOS

  1 files  ±0   15 suites  ±0   7m 54s ⏱️ +16s
 96 tests ±0   96 ✅ ±0  0 💤 ±0  0 ❌ ±0 
100 runs  ±0  100 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 080d475. ± Comparison against base commit ec4ce3e.

This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.
Custom_WithoutAbi_FailNativeSucceedWebGL
Custom_WithoutAbi_Fetch

♻️ This comment has been updated with latest results.

@0xFirekeeper 0xFirekeeper merged commit 9e90d61 into main Apr 10, 2024
13 checks passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/contract-fetch-abi branch April 10, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant