Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EmbeddedWallet -> InAppWallet - Scripts, Prefabs, Files #175

Merged
merged 4 commits into from
Apr 12, 2024

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Apr 11, 2024

PR-Codex overview

The focus of this PR is to replace the Embedded Wallet SDK with the In-App Wallet SDK, updating related classes, prefabs, and properties.

Detailed summary

  • Replaced Embedded Wallet with In-App Wallet SDK
  • Updated prefabs and scripts related to wallet connections
  • Modified authentication options for In-App Wallet
  • Renamed UI elements from Embedded to In-App Wallet

The following files were skipped due to too many changes: Assets/Thirdweb/Core/Scripts/WalletsUI/EmbeddedWalletUI.cs, Assets/Thirdweb/Examples/Scripts/Prefabs/Prefab_ConnectWallet.cs, Assets/WebGLTemplates/Thirdweb/lib/thirdweb-unity-bridge.js

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

github-actions bot commented Apr 11, 2024

Test Results for iOS

  1 files  ±0   15 suites  ±0   6m 58s ⏱️ +19s
 96 tests ±0   96 ✅ ±0  0 💤 ±0  0 ❌ ±0 
100 runs  ±0  100 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a36d3ac. ± Comparison against base commit b1f9d4c.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 11, 2024

Test Results for WebGL

  1 files  ±0   15 suites  ±0   7m 17s ⏱️ +40s
 96 tests ±0   96 ✅ ±0  0 💤 ±0  0 ❌ ±0 
100 runs  ±0  100 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a36d3ac. ± Comparison against base commit b1f9d4c.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 11, 2024

Test Results for Android

  1 files  ±0   15 suites  ±0   8m 24s ⏱️ + 1m 24s
 96 tests ±0   96 ✅ ±0  0 💤 ±0  0 ❌ ±0 
100 runs  ±0  100 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a36d3ac. ± Comparison against base commit b1f9d4c.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 11, 2024

Test Results for StandaloneLinux64

  1 files  ±0   15 suites  ±0   6m 50s ⏱️ +16s
 96 tests ±0   96 ✅ ±0  0 💤 ±0  0 ❌ ±0 
100 runs  ±0  100 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a36d3ac. ± Comparison against base commit b1f9d4c.

♻️ This comment has been updated with latest results.

@0xFirekeeper 0xFirekeeper merged commit 1235c8b into main Apr 12, 2024
13 checks passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/inappwallet branch May 17, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant