Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buy With Fiat API // Scene_Pay #178

Merged
merged 17 commits into from
May 14, 2024
Merged

Buy With Fiat API // Scene_Pay #178

merged 17 commits into from
May 14, 2024

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Apr 18, 2024

PR-Codex overview

The focus of this PR is to enhance the payment functionality by adding support for buying with fiat, introducing new endpoints, and improving history tracking.

Detailed summary

  • Added support for buying with fiat using onramp links
  • Introduced new endpoints for crypto and fiat transactions
  • Enhanced history tracking for buy operations
  • Updated UI text and method names for clarity

The following files were skipped due to too many changes: Assets/Thirdweb/Core/Scripts/Pay/Types.GetBuyWithCryptoStatus.cs, Assets/Thirdweb/Core/Scripts/Pay/ThirdwebPay.GetBuyWithCryptoHistory.cs, Assets/Thirdweb/Core/Scripts/Pay/Types.GetBuyWithFiatStatus.cs, Assets/Thirdweb/Core/Scripts/Pay/ThirdwebPay.GetBuyWithFiatCurrencies.cs, Assets/Thirdweb/Core/Scripts/Pay/ThirdwebPay.GetBuyWithFiatStatus.cs, Assets/Thirdweb/Core/Scripts/Pay/ThirdwebPay.GetBuyWithFiatQuote.cs, Assets/Thirdweb/Core/Scripts/Pay/Types.GetBuyWithFiatQuote.cs, Assets/Thirdweb/Examples/Scripts/Prefabs/Prefab_BuyWithFiat.cs, Assets/Thirdweb/Examples/Scenes/Scene_Pay.unity, Assets/Thirdweb/Examples/Prefabs/Prefab_BuyWithFiat.prefab

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@0xFirekeeper 0xFirekeeper marked this pull request as draft April 18, 2024 02:14
Copy link

github-actions bot commented Apr 18, 2024

Test Results for iOS

  1 files  ±0   15 suites  ±0   7m 38s ⏱️ -41s
 96 tests ±0   96 ✅ ±0  0 💤 ±0  0 ❌ ±0 
100 runs  ±0  100 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3e3de5f. ± Comparison against base commit 69ca41f.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 18, 2024

Test Results for Android

  1 files  ±0   15 suites  ±0   7m 27s ⏱️ +14s
 96 tests ±0   96 ✅ ±0  0 💤 ±0  0 ❌ ±0 
100 runs  ±0  100 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3e3de5f. ± Comparison against base commit 69ca41f.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 18, 2024

Test Results for StandaloneLinux64

  1 files  ±0   15 suites  ±0   7m 33s ⏱️ +14s
 96 tests ±0   96 ✅ ±0  0 💤 ±0  0 ❌ ±0 
100 runs  ±0  100 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3e3de5f. ± Comparison against base commit 69ca41f.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 18, 2024

Test Results for WebGL

  1 files  ±0   15 suites  ±0   8m 32s ⏱️ + 1m 22s
 96 tests ±0   96 ✅ ±0  0 💤 ±0  0 ❌ ±0 
100 runs  ±0  100 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3e3de5f. ± Comparison against base commit 69ca41f.

♻️ This comment has been updated with latest results.

@0xFirekeeper 0xFirekeeper marked this pull request as ready for review April 20, 2024 04:02
@0xFirekeeper 0xFirekeeper merged commit 4b24a66 into main May 14, 2024
12 of 13 checks passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/onramp branch May 17, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant