Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix main thread encryption/decryption freeze #180

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Apr 25, 2024

A little slower for LocalWallet but better UX
Not doing this for EWS due to much heavier crypto operations that might take 10+ seconds to initial encryption, specially bad on mobile, best to do on main thread freeze 1-2s


PR-Codex overview

The focus of this PR is to implement asynchronous operations in key generation and account unlocking processes.

Detailed summary

  • Updated methods in Wallet.cs, ThirdwebLocalWallet.cs, and Utils.cs to use async and await for asynchronous operations.
  • Replaced synchronous file operations with asynchronous operations for improved performance.
  • Modified return types to Task or Task<string> for asynchronous handling.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

Test Results for iOS

  1 files  ±0   15 suites  ±0   6m 56s ⏱️ -44s
 96 tests ±0   96 ✅ ±0  0 💤 ±0  0 ❌ ±0 
100 runs  ±0  100 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit b8979c2. ± Comparison against base commit 493f6ae.

Copy link

Test Results for WebGL

  1 files  ±0   15 suites  ±0   6m 46s ⏱️ -52s
 96 tests ±0   96 ✅ ±0  0 💤 ±0  0 ❌ ±0 
100 runs  ±0  100 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit b8979c2. ± Comparison against base commit 493f6ae.

Copy link

Test Results for Android

  1 files  ±0   15 suites  ±0   7m 6s ⏱️ -24s
 96 tests ±0   96 ✅ ±0  0 💤 ±0  0 ❌ ±0 
100 runs  ±0  100 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit b8979c2. ± Comparison against base commit 493f6ae.

Copy link

Test Results for StandaloneLinux64

  1 files  ±0   15 suites  ±0   7m 13s ⏱️ -14s
 96 tests ±0   96 ✅ ±0  0 💤 ±0  0 ❌ ±0 
100 runs  ±0  100 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit b8979c2. ± Comparison against base commit 493f6ae.

@0xFirekeeper 0xFirekeeper merged commit fadb271 into main Apr 25, 2024
13 checks passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/unblock-main-thread branch April 25, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant