Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate WC Modal, Upgrade SDK, Multichain & Multiaccount #189

Merged
merged 7 commits into from
May 28, 2024

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented May 27, 2024

PR-Codex overview

The focus of this PR is updating dependencies and adding new functionalities to the WalletConnectUnity project.

Detailed summary

  • Updated dependencies for com.walletconnect.core
  • Added new methods to handle wallets in WalletUtils.cs
  • Modified device type detection logic in DeviceUtils.cs
  • Added new classes and meta files for com.walletconnect.nethereum

The following files were skipped due to too many changes: Assets/Thirdweb/Core/Plugins/WalletConnectUnity/com.walletconnect.core/Runtime/Utils/DeviceUtils.cs, Assets/Thirdweb/Core/Plugins/WalletConnectUnity/com.walletconnect.core/Runtime/ProjectConfiguration.cs, Assets/Thirdweb/Core/Plugins/WalletConnectUnity/com.walletconnect.nethereum/README.md, Assets/Thirdweb/Core/Scripts/ThirdwebSession.cs, Assets/Thirdweb/Core/Plugins/WalletConnectUnity/com.walletconnect.core/Runtime/IWalletConnect.cs, Assets/Thirdweb/Core/Plugins/WalletConnectUnity/com.walletconnect.core/Runtime/EVM/Extensions.cs, Assets/Thirdweb/Core/Plugins/WalletConnectUnity/com.walletconnect.core/Runtime/WalletConnectSharp/External/System.Reactive.dll.meta, Assets/Thirdweb/Core/Plugins/WalletConnectUnity/com.walletconnect.nethereum/LICENSE, Assets/Thirdweb/Core/Plugins/WalletConnectUnity/com.walletconnect.core/Runtime/WalletConnectSharp/External/Websocket.Client.dll.meta, Assets/Thirdweb/Core/Plugins/WalletConnectUnity/com.walletconnect.core/Runtime/WalletConnectSharp/External/System.Threading.Channels.dll.meta, Assets/Thirdweb/Core/Plugins/WalletConnectUnity/com.walletconnect.core/Runtime/WalletConnectSharp/External/Microsoft.IdentityModel.Tokens.dll.meta, Assets/Thirdweb/Core/Plugins/WalletConnectUnity/com.walletconnect.core/Runtime/WalletConnectSharp/External/Microsoft.IdentityModel.Logging.dll.meta, Assets/Thirdweb/Core/Plugins/WalletConnectUnity/com.walletconnect.core/Runtime/WalletConnectSharp/External/Microsoft.IdentityModel.Abstractions.dll.meta, Assets/Thirdweb/Core/Scripts/Wallets/ThirdwebWalletConnect.cs, Assets/Thirdweb/Core/Plugins/WalletConnectUnity/com.walletconnect.core/Runtime/UnityEventsDispatcher.cs, Assets/Thirdweb/Core/Plugins/WalletConnectUnity/com.walletconnect.core/Runtime/WalletConnectSharp/External/BouncyCastle.Crypto.dll.meta, Assets/Thirdweb/Core/Plugins/WalletConnectUnity/com.walletconnect.core/Runtime/EVM/Methods.cs, Assets/Thirdweb/Core/Plugins/WalletConnectUnity/com.walletconnect.nethereum/Runtime/WalletConnectService.cs, Assets/Thirdweb/Core/Plugins/WalletConnectUnity/com.walletconnect.core/Runtime/EVM/Model.cs, Assets/Thirdweb/Core/Plugins/WalletConnectUnity/com.walletconnect.nethereum/Runtime/WalletConnectUnityInterceptor.cs, Assets/Thirdweb/Core/Plugins/WalletConnectUnity/com.walletconnect.core/CHANGELOG.md, Assets/Thirdweb/Core/Scripts/AccountAbstraction/Core/SmartWallet.cs, Assets/Thirdweb/Core/Plugins/WalletConnectUnity/com.walletconnect.nethereum/Runtime/WalletConnectServiceCore.cs, Assets/Thirdweb/Core/Plugins/WalletConnectUnity/com.walletconnect.core/Runtime/Linker.cs, Assets/Thirdweb/Core/Scripts/WalletsUI/WalletConnectUI.cs, Assets/Thirdweb/Core/Plugins/WalletConnectUnity/com.walletconnect.nethereum/Runtime/WalletConnectInterceptor.cs, Assets/Thirdweb/Core/Plugins/WalletConnectUnity/com.walletconnect.core/Runtime/External/NativeWebSocket/WebSocket.jslib, Assets/Thirdweb/Core/Plugins/WalletConnectUnity/com.walletconnect.core/Runtime/WebSocketConnection.cs, Assets/Thirdweb/Core/Prefabs/WalletProvider_WalletConnect.prefab, Assets/Thirdweb/Core/Scripts/ThirdwebInterceptor.cs, Assets/Thirdweb/Core/Plugins/WalletConnectUnity/com.walletconnect.core/Runtime/Chain.cs, Assets/Thirdweb/Core/Plugins/WalletConnectUnity/com.walletconnect.core/Runtime/WalletConnect.cs, Assets/Thirdweb/Core/Plugins/WalletConnectUnity/com.walletconnect.core/Runtime/External/NativeWebSocket/WebSocket.cs

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

socket-security bot commented May 27, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 0 B
npm/[email protected] None 0 0 B
npm/[email protected] None 0 0 B

🚮 Removed packages: npm/[email protected]

View full report↗︎

Copy link

github-actions bot commented May 27, 2024

Test Results for iOS

  1 files  ±0   15 suites  ±0   7m 40s ⏱️ -13s
 96 tests ±0   96 ✅ ±0  0 💤 ±0  0 ❌ ±0 
100 runs  ±0  100 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 34074ff. ± Comparison against base commit 80f5652.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 27, 2024

Test Results for WebGL

  1 files  ±0   15 suites  ±0   7m 31s ⏱️ -12s
 96 tests ±0   96 ✅ ±0  0 💤 ±0  0 ❌ ±0 
100 runs  ±0  100 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 34074ff. ± Comparison against base commit 80f5652.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 27, 2024

Test Results for StandaloneLinux64

  1 files  ±0   15 suites  ±0   7m 28s ⏱️ -19s
 96 tests ±0   96 ✅ ±0  0 💤 ±0  0 ❌ ±0 
100 runs  ±0  100 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 34074ff. ± Comparison against base commit 80f5652.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 27, 2024

Test Results for Android

  1 files  ±0   15 suites  ±0   7m 39s ⏱️ -11s
 96 tests ±0   96 ✅ ±0  0 💤 ±0  0 ❌ ±0 
100 runs  ±0  100 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 34074ff. ± Comparison against base commit 80f5652.

♻️ This comment has been updated with latest results.

@0xFirekeeper 0xFirekeeper changed the title Upgrade WalletConnect, add multichain, interceptor Integrate WC Modal, Upgrade SDK, Multichain & Multiaccount May 28, 2024
@0xFirekeeper 0xFirekeeper merged commit 861a729 into main May 28, 2024
7 checks passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/wc-upgrade-nethereum branch May 28, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant