Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebGL] Force eth_signTypedData_v4 webgl session req #199

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Jun 11, 2024

Potential fix to some wallets sometimes failing to sign single chain init eth_signTypedData requests in WebGL


PR-Codex overview

This PR updates the thirdweb-unity-bridge.js file by adding a TypedDataEncoder class and resolving naming conventions.

Detailed summary

  • Added TypedDataEncoder class for encoding data types
  • Improved naming conventions for better readability and consistency

The following files were skipped due to too many changes: Assets/WebGLTemplates/Thirdweb/lib/thirdweb-unity-bridge.js

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Potential fix to some wallets failing to sign single chain init requests
Copy link

github-actions bot commented Jun 11, 2024

Test Results for StandaloneLinux64

  1 files  ±0   16 suites  ±0   8m 12s ⏱️ +16s
102 tests ±0  102 ✅ ±0  0 💤 ±0  0 ❌ ±0 
106 runs  ±0  106 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit beeda4d. ± Comparison against base commit ac7d3ca.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 11, 2024

Test Results for iOS

  1 files  ±0   16 suites  ±0   8m 4s ⏱️ +34s
102 tests ±0  102 ✅ ±0  0 💤 ±0  0 ❌ ±0 
106 runs  ±0  106 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit beeda4d. ± Comparison against base commit ac7d3ca.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 11, 2024

Test Results for WebGL

  1 files  ±0   16 suites  ±0   8m 4s ⏱️ +22s
102 tests ±0  102 ✅ ±0  0 💤 ±0  0 ❌ ±0 
106 runs  ±0  106 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit beeda4d. ± Comparison against base commit ac7d3ca.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 11, 2024

Test Results for Android

  1 files  ±0   16 suites  ±0   8m 19s ⏱️ +4s
102 tests ±0  102 ✅ ±0  0 💤 ±0  0 ❌ ±0 
106 runs  ±0  106 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit beeda4d. ± Comparison against base commit ac7d3ca.

♻️ This comment has been updated with latest results.

@0xFirekeeper 0xFirekeeper changed the title Force eth_signTypedData_v4 webgl session req [WebGL] Force eth_signTypedData_v4 webgl session req Jun 11, 2024
@0xFirekeeper 0xFirekeeper merged commit a95c931 into main Jun 11, 2024
13 checks passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/webgl-wc-v4-typeddata branch June 11, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant