Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cross-Platform] ZkCandy Sepolia AA Support #201

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Jun 11, 2024

PR-Codex overview

This PR introduces a new method IsZkSyncChain to check for specific chain IDs. It also refactors existing chain ID checks to use this method.

Detailed summary

  • Added IsZkSyncChain method to check for specific chain IDs
  • Refactored existing chain ID checks to use the new method

The following files were skipped due to too many changes: Assets/WebGLTemplates/Thirdweb/lib/thirdweb-unity-bridge.js

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

Test Results for Android

  1 files  ±0   16 suites  ±0   8m 24s ⏱️ +16s
102 tests ±0  102 ✅ ±0  0 💤 ±0  0 ❌ ±0 
106 runs  ±0  106 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 592e6c3. ± Comparison against base commit 5026d3d.

Copy link

Test Results for iOS

  1 files  ±0   16 suites  ±0   8m 24s ⏱️ -13s
102 tests ±0  102 ✅ ±0  0 💤 ±0  0 ❌ ±0 
106 runs  ±0  106 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 592e6c3. ± Comparison against base commit 5026d3d.

Copy link

Test Results for WebGL

  1 files  ±0   16 suites  ±0   8m 18s ⏱️ +2s
102 tests ±0  102 ✅ ±0  0 💤 ±0  0 ❌ ±0 
106 runs  ±0  106 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 592e6c3. ± Comparison against base commit 5026d3d.

Copy link

Test Results for StandaloneLinux64

  1 files  ±0   16 suites  ±0   8m 50s ⏱️ +32s
102 tests ±0  102 ✅ ±0  0 💤 ±0  0 ❌ ±0 
106 runs  ±0  106 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 592e6c3. ± Comparison against base commit 5026d3d.

@0xFirekeeper 0xFirekeeper merged commit 5b590dd into main Jun 11, 2024
13 checks passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/zkcandy-sepolia branch June 11, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant