Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Broken link, wrong image for graphql course #779

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

vyktoremario
Copy link
Contributor

Type of change

  • Content addition
  • Bug fix
  • Behavior change

Summary of change

With respect to the GraphQL DataLoader JS marathon course:

  • The logo should be This Dot and not Star's profile image

  • Clicking on the card does not go to YouTube

Checklist

@netlify
Copy link

netlify bot commented Oct 17, 2023

Deploy Preview for framework-dev canceled.

Name Link
🔨 Latest commit 60112c3
🔍 Latest deploy log https://app.netlify.com/sites/framework-dev/deploys/652ea237e94124000a5e8b07

@netlify
Copy link

netlify bot commented Oct 17, 2023

Deploy Preview for node-framework-dev canceled.

Name Link
🔨 Latest commit 60112c3
🔍 Latest deploy log https://app.netlify.com/sites/node-framework-dev/deploys/652ea23740e8a000088632de

@netlify
Copy link

netlify bot commented Oct 17, 2023

👷 Deploy Preview for qwik-framework-dev processing.

Name Link
🔨 Latest commit 60112c3
🔍 Latest deploy log https://app.netlify.com/sites/qwik-framework-dev/deploys/652ea237a84973000849d650

@netlify
Copy link

netlify bot commented Oct 17, 2023

Deploy Preview for qwik-framework-dev canceled.

Name Link
🔨 Latest commit 60112c3
🔍 Latest deploy log https://app.netlify.com/sites/qwik-framework-dev/deploys/652ea237a84973000849d650

@netlify
Copy link

netlify bot commented Oct 17, 2023

Deploy Preview for system-framework-dev canceled.

Name Link
🔨 Latest commit 60112c3
🔍 Latest deploy log https://app.netlify.com/sites/system-framework-dev/deploys/652ea237dcf1f100087061d8

@netlify
Copy link

netlify bot commented Oct 17, 2023

Deploy Preview for react-framework-dev canceled.

Name Link
🔨 Latest commit 60112c3
🔍 Latest deploy log https://app.netlify.com/sites/react-framework-dev/deploys/652ea237ca838a0008bfdc70

@netlify
Copy link

netlify bot commented Oct 17, 2023

Deploy Preview for svelte-framework-dev canceled.

Name Link
🔨 Latest commit 60112c3
🔍 Latest deploy log https://app.netlify.com/sites/svelte-framework-dev/deploys/652ea237e0cb0e0008c4280f

@netlify
Copy link

netlify bot commented Oct 17, 2023

Deploy Preview for solid-framework-dev canceled.

Name Link
🔨 Latest commit 60112c3
🔍 Latest deploy log https://app.netlify.com/sites/solid-framework-dev/deploys/652ea237656a9a000811e1fe

@netlify
Copy link

netlify bot commented Oct 17, 2023

Deploy Preview for deno-framework-dev canceled.

Name Link
🔨 Latest commit 60112c3
🔍 Latest deploy log https://app.netlify.com/sites/deno-framework-dev/deploys/652ea237ca838a0008bfdc75

@netlify
Copy link

netlify bot commented Oct 17, 2023

👷 Deploy Preview for vue-framework-dev processing.

Name Link
🔨 Latest commit 60112c3
🔍 Latest deploy log https://app.netlify.com/sites/vue-framework-dev/deploys/652ea23756d41c0008842d10

@netlify
Copy link

netlify bot commented Oct 17, 2023

Deploy Preview for vue-framework-dev canceled.

Name Link
🔨 Latest commit 60112c3
🔍 Latest deploy log https://app.netlify.com/sites/vue-framework-dev/deploys/652ea23756d41c0008842d10

@netlify
Copy link

netlify bot commented Oct 17, 2023

Deploy Preview for graphql-framework-dev ready!

Name Link
🔨 Latest commit 60112c3
🔍 Latest deploy log https://app.netlify.com/sites/graphql-framework-dev/deploys/652ea237f219b2000888e29c
😎 Deploy Preview https://deploy-preview-779--graphql-framework-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 17, 2023

Deploy Preview for angular-framework-dev canceled.

Name Link
🔨 Latest commit 60112c3
🔍 Latest deploy log https://app.netlify.com/sites/angular-framework-dev/deploys/652ea237ae6598000849ab91

@vyktoremario vyktoremario merged commit 756799e into main Oct 24, 2023
35 checks passed
@vyktoremario vyktoremario deleted the fix-broken-link-and-logo branch October 24, 2023 15:24
@thisdot-bot
Copy link

Hi @vyktoremario. 👋

Your PR has been approved and merged. 🎉

Thank you for your continued contributions to framework.dev. ❤️

Keep up the great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add data loaders JS Marathon to courses
3 participants