tests: add names to dump test cases #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just a nit-picky typo fix.
Can't see where it would still be used.
This forces the writing of commas in arrays/slices/maps. Useful in tests to avoid false positives when diffing.
DisableUnexported specifies whether to disable the unexported fields of struct. This is useful for debugging APIs.
This carries the opinionated "best" config for clean dumping.
This dumps lists in a more JSON-ish style
Print empty lists, maps and structs in short `[]` and `{}` form.
|
It also adds benchmarks for Dump, as sub-benchmarks. |
|
Interesting - I wasn't really maintaining this repo actively... I didn't realize people were using it. |
|
I will have to make some time to figure out if I intend to support this or not. Will circle back ASAP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make tests more approachable, I've changed the Dump cases into sub-tests with the type as test name.
I don't have any problem with updating the Formatter tests also in this style.