idiag: "fix" license for "idiag-socket-details" tool #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is fine with me. For what it's worth, Sassano Systems was my LLC that I wholly owned and controlled while it existed. I shut down that LLC many years ago. |
ice799
approved these changes
Aug 4, 2023
This tool had a GPL-2.0-only license text when it was added. That is not what we require for libnl3 contributions. Since being added, the file was only touched by me (Thomas Haller) and Yegor Yefremov. Those are all trivial contributions. This leaves Joe Damato, who initially contributed the file. Joe agrees with this adjustment of the license (Thanks!!). Note that there is also a line: Copyright (c) 2013 Sassano Systems LLC <[email protected]> Apparently, the copyright for the contribution is also with Joe, so there is no further problem. Fixes: c97c8c2 ('Add idiag-socket-details') #354
thom311
force-pushed
the
th/idiag-socket-details-lgpl
branch
from
cfa3f84
to
680df17
Compare
|
Merged. Thank you @ice799, for reporting back and your agreement!!!!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tool had a GPL-2.0-only license text when it was added. That is not what we expect for libnl3 contributions.
Since being added, the file was only touched by me (Thomas Haller) and Yegor Yefremov. Yegor only added a SPDX license identifier and I am fine that all my (trivial) changes to the file are LGPL-2.0-only compatible.
This leaves only Joe Damato, who initially contributed the file. Joe agrees with this adjustment of the license.
Note that there is also a line:
I don't know what Sassano Systems says about this. The file seems small enough, to justify this change. It was always a "honest mistake".
The alternative would be to delete the file, which is probably in nobody's interest.
Fixes: c97c8c2 ('Add idiag-socket-details')