lib/route: add rtnl_neigh ext flags support #405
Conversation
|
hm, while internally kernel merges the 8 bit flags with the ext-flags neigh_flags_ext = pn->flags >> NTF_EXT_SHIFT;
neigh_flags = pn->flags & NTF_OLD_MASK;on the netlink API these are basically independent flags (for example, Anyway. Since in the kernel API this looks like separate flags, it is also right that they are treated this way in the libnl API. This approach requires us to add 5 new public API functions, when otherwise the existing API was already suitable to express 32bit flags. |
ronand-atl
force-pushed
the
add-neigh-ext-flags-support
branch
2 times, most recently
from
cc8cf42
to
039b25b
Compare
ronand-atl
force-pushed
the
add-neigh-ext-flags-support
branch
from
039b25b
to
f062ebc
Compare
The amount of flags that could be stored in the ndm_flags field of ndmsg was limited to 8, so the kernel introduced a new attribute so more flags could be represented in netlink messages. Add support for the extended neighbour flags.
ronand-atl
force-pushed
the
add-neigh-ext-flags-support
branch
from
f062ebc
to
f06188d
Compare
|
Just fixed that small issue and squashed the commits. Let me know if there's any other changes you want me to make, otherwise it should be good to merge :) |
The amount of flags that could be stored in the ndm_flags field of ndmsg was limited to 8, so the kernel introduced a new attribute so more flags could be represented in netlink messages. Add support for the extended neighbour flags. #405
|
lgtm. Merged as 014c33a Thank you! |
This PR adds support for extended neighbor flags which are sent as an attribute.
A use case for this feature is being able to detect if an FDB entry has the locked flag set.