Small coding style fixes #246
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| warn "Your current version of Bundler does not support parallel installation. Please " + | ||
| "upgrade Bundler to version >= 1.4.0, or invoke `appraisal` without `--jobs` option." | ||
| warn "Your current version of Bundler does not support parallel installation. Please " \ | ||
| "upgrade Bundler to version >= 1.4.0, or invoke `appraisal` without `--jobs` option." |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [100/80]
| @@ -161,8 +161,8 @@ def bundle_options(options) | |||
| if Utils.support_parallel_installation? | |||
| options_strings << "--jobs=#{jobs}" | |||
| else | |||
| warn "Your current version of Bundler does not support parallel installation. Please " + | |||
| "upgrade Bundler to version >= 1.4.0, or invoke `appraisal` without `--jobs` option." | |||
| warn "Your current version of Bundler does not support parallel installation. Please " \ | |||
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [98/80]
| @@ -54,11 +54,11 @@ def strip_heredoc(string) | |||
| method_option "retry", type: :numeric, default: 1, | |||
| desc: "Retry network and git requests that have failed" | |||
| method_option "without", banner: "GROUP_NAMES", | |||
| desc: "A space-separated list of groups referencing gems to skip " + | |||
| "during installation. Bundler will remember this option." | |||
| desc: "A space-separated list of groups referencing gems to skip " \ | |||
There was a problem hiding this comment.
Layout/AlignHash: Align the elements of a hash literal if they span more than one line.
| @@ -15,7 +15,7 @@ def to_s | |||
| if @options.empty? | |||
| "git #{Utils.prefix_path(@source).inspect} do\n#{indent(super)}\nend" | |||
| else | |||
| "git #{Utils.prefix_path(@source).inspect}, #{Utils.format_string(@options)} do\n" + | |||
| "git #{Utils.prefix_path(@source).inspect}, #{Utils.format_string(@options)} do\n" \ | |||
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [92/80]
| @@ -15,7 +15,7 @@ def to_s | |||
| if @options.empty? | |||
| "path #{Utils.prefix_path(@source).inspect} do\n#{indent(super)}\nend" | |||
| else | |||
| "path #{Utils.prefix_path(@source).inspect}, #{Utils.format_string(@options)} do\n" + | |||
| "path #{Utils.prefix_path(@source).inspect}, #{Utils.format_string(@options)} do\n" \ | |||
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [93/80]
| warn "`rake appraisal:#{appraisal.name}` task is deprecated and will be removed soon. " + | ||
| "Please use `appraisal #{appraisal.name} rake #{ARGV.join(' ')}`." | ||
| warn "`rake appraisal:#{appraisal.name}` task is deprecated and will be removed soon. " \ | ||
| "Please use `appraisal #{appraisal.name} rake #{ARGV.join(' ')}`." |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [85/80]
| @@ -35,8 +35,8 @@ def initialize | |||
| desc "DEPRECATED: Run the given task for appraisal #{appraisal.name}" | |||
| task appraisal.name do | |||
| ARGV.shift | |||
| warn "`rake appraisal:#{appraisal.name}` task is deprecated and will be removed soon. " + | |||
| "Please use `appraisal #{appraisal.name} rake #{ARGV.join(' ')}`." | |||
| warn "`rake appraisal:#{appraisal.name}` task is deprecated and will be removed soon. " \ | |||
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [103/80]
| exec "bundle exec appraisal install" | ||
| end | ||
|
|
||
| desc "DEPRECATED: Remove all generated gemfiles from gemfiles/ folder" | ||
| task :cleanup do | ||
| warn "`rake appraisal:cleanup` task is deprecated and will be removed soon. " + | ||
| "Please use `appraisal clean`." | ||
| warn "`rake appraisal:cleanup` task is deprecated and will be removed soon. " \ |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [89/80]
| exec "bundle exec appraisal generate" | ||
| end | ||
|
|
||
| desc "DEPRECATED: Resolve and install dependencies for each appraisal" | ||
| task :install do | ||
| warn "`rake appraisal:install` task is deprecated and will be removed soon. " + | ||
| "Please use `appraisal install`." | ||
| warn "`rake appraisal:install` task is deprecated and will be removed soon. " \ |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [89/80]
| @@ -11,22 +11,22 @@ def initialize | |||
| namespace :appraisal do | |||
| desc "DEPRECATED: Generate a Gemfile for each appraisal" | |||
| task :gemfiles do | |||
| warn "`rake appraisal:gemfile` task is deprecated and will be removed soon. " + | |||
| "Please use `appraisal generate`." | |||
| warn "`rake appraisal:gemfile` task is deprecated and will be removed soon. " \ | |||
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [89/80]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you!