Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated env method, bump version to 1.3.0 #65

Merged
merged 2 commits into from
Sep 24, 2024
Merged

remove deprecated env method, bump version to 1.3.0 #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fc4e1b
remove deprecated env method, bump version to 1.3.0
dorianmariecom Aug 17, 2024
9848ce7
Merge branch 'main' into dorian/env
dorianmariecom Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions lib/climate_control.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,6 @@ def unsafe_modify(environment_overrides = {}, &block)
merge(ENV, previous: previous, middle: middle, after: after)
end

deprecate :unsafe_modify, :modify, 2024, 11

def env
ENV
end

deprecate :env, "ENV", 2022, 10

private

def copy(overrides)
Expand Down
2 changes: 1 addition & 1 deletion lib/climate_control/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module ClimateControl
VERSION = "1.2.0".freeze
VERSION = "1.3.0".freeze
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't change versions outside the release commit — this makes it easier to see when the release was cut, especially as it'll include CHANGELOG entries too.

I'd also generally wait until releasing a major version. We don't know who's relying on a deprecated method, and seeing a major version coming in and then you're tests failing all of a sudden is a better hint.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I am sorry, Nick! I saw that this method had been deprecated for a while and didn't see any issues. I was planning on cutting a release announcing the deprecation. I will rollback the commit and reopen this PR.

end
Loading