Introduce suspenders:factories generator
#1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevepolitodesign
force-pushed
the
factory-bot-generator
branch
from
856e821
to
ed5e4a6
Compare
Comment on lines
10
to
12
| destination Rails.root | ||
| setup :prepare_destination | ||
| teardown :restore_destination |
There was a problem hiding this comment.
destination is set to test/dummy, which is a blank Rails app.
setup and teardown handle adding or removing files needed for this specific test to run. For example, adding the Gemfile.
crackofdusk
reviewed
Oct 30, 2023
stevepolitodesign
force-pushed
the
suspenders-3-0-0
branch
from
44f783e
to
2a0f7ff
Compare
stevepolitodesign
force-pushed
the
factory-bot-generator
branch
4 times, most recently
from
d1aa50b
to
e93890a
Compare
stevepolitodesign
force-pushed
the
suspenders-3-0-0
branch
from
2a0f7ff
to
84e0c95
Compare
stevepolitodesign
force-pushed
the
factory-bot-generator
branch
2 times, most recently
from
574f067
to
197137f
Compare
stevepolitodesign
force-pushed
the
factory-bot-generator
branch
from
197137f
to
e2e3f0b
Compare
This comment was marked as resolved.
This comment was marked as resolved.
@mike-burns that was an oversite on my part. Fixed here: 1455dc1 |
stevepolitodesign
changed the title
suspenders:factory_bot generatorsuspenders:factories generator
stevepolitodesign
force-pushed
the
factory-bot-generator
branch
2 times, most recently
from
50f1603
to
d2e4b85
Compare
mike-burns
reviewed
Nov 9, 2023
stevepolitodesign
force-pushed
the
factory-bot-generator
branch
from
d2e4b85
to
6f436bf
Compare
mike-burns
approved these changes
Nov 17, 2023
stevepolitodesign
force-pushed
the
factory-bot-generator
branch
from
7409c81
to
012dbad
Compare
Maintains functionally with the [existing generator][] while adding support for the [default Rails test suite]. With this change, the generator can be invoked on a Rails application that uses RSpec and the default Rails test suite. Adds generator which adds a test to lint all Factories in an effort to improve developer experience. Additionally, we remove the generation of the `dev:prime` task as we felt that should be the responsibly of another generator. [existing generator]: https://github.com/thoughtbot/suspenders/blob/main/lib/suspenders/generators/factories_generator.rb [default Rails test suite]: https://guides.rubyonrails.org/testing.html
stevepolitodesign
force-pushed
the
factory-bot-generator
branch
from
012dbad
to
314dd72
Compare
stevepolitodesign
added a commit
that referenced
this pull request
May 10, 2024
Maintains functionally with the [existing generator][] while adding support for the [default Rails test suite]. With this change, the generator can be invoked on a Rails application that uses RSpec or the [default Rails test suite][]. Adds generator which adds a test to lint all Factories in an effort to improve developer experience. Additionally, we remove the generation of the `dev:prime` task as we felt that should be the responsibly of another generator. [existing generator]: https://github.com/thoughtbot/suspenders/blob/main/lib/suspenders/generators/factories_generator.rb [default Rails test suite]: https://guides.rubyonrails.org/testing.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintains functionally with the existing generator while adding
support for the default Rails test suite. With this change, the
generator can be invoked on a Rails application that use RSpec and the
default Rails test suite.
Adds generator which adds a test to lint all Factories in an effort to
improve developer experience.
Additionally, we remove the generation of the
dev:primetask as wefelt that should be the responsibly of another generator.
How to review this pull request
Review is easier when compared with the existing generator.
Additionally, if you want to manually test these changes, spin up a new rails app and add the following: