Introduce suspenders:advisories generator
#1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevepolitodesign
force-pushed
the
advisories_generator
branch
from
9e2e4f5
to
391de5c
Compare
This was referenced Nov 9, 2023
Merged
stevepolitodesign
added a commit
that referenced
this pull request
Nov 11, 2023
Closes #1138 Closes #1143 Consolidates logic from the existing [advisories][] and [lint][] generators to create a default Rake task that audits and lints the codebase. We do this because it's simpler to bundle this configuration together, rather than have two separate generators compete to modify the default Rake task, since those generators can be run independently. [advisories]: https://github.com/thoughtbot/suspenders/blob/main/lib/suspenders/generators/advisories_generator.rb [lint]: https://github.com/thoughtbot/suspenders/blob/main/lib/suspenders/generators/lint_generator.rb
stevepolitodesign
added a commit
that referenced
this pull request
Nov 11, 2023
Closes #1138 Closes #1143 Consolidates logic from the existing [advisories][] and [lint][] generators to create a default Rake task that audits and lints the codebase. We do this because it's simpler to bundle this configuration together, rather than have two separate generators compete to modify the default Rake task, since those generators can be run independently. [advisories]: https://github.com/thoughtbot/suspenders/blob/main/lib/suspenders/generators/advisories_generator.rb [lint]: https://github.com/thoughtbot/suspenders/blob/main/lib/suspenders/generators/lint_generator.rb
stevepolitodesign
added a commit
that referenced
this pull request
Nov 11, 2023
Closes #1138 Closes #1143 Consolidates logic from the existing [advisories][] and [lint][] generators to create a default Rake task that audits and lints the codebase. We do this because it's simpler to bundle this configuration together, rather than have two separate generators compete to modify the default Rake task, since those generators can be run independently. [advisories]: https://github.com/thoughtbot/suspenders/blob/main/lib/suspenders/generators/advisories_generator.rb [lint]: https://github.com/thoughtbot/suspenders/blob/main/lib/suspenders/generators/lint_generator.rb
stevepolitodesign
force-pushed
the
advisories_generator
branch
4 times, most recently
from
5ee7eed
to
3dc2fe1
Compare
Uses the [bundler-audit][] gem to update the local security database and show any relevant issues with the app's dependencies. This generator is only responsible for installing the gem and adding the Rake task. The [original implementation][] was written in 2014, and is no longer relevant. This is because the gem ships [with a Rake task][] that can be set as the default task, which will be addressed in #1144 Also exposes `backup_file` and `restore_file` test helpers into the public API. [bundler-audit]: https://github.com/rubysec/bundler-audit [original implementation]: e23157e [with a Rake task]: https://github.com/rubysec/bundler-audit#rake-tasks
stevepolitodesign
force-pushed
the
advisories_generator
branch
from
3dc2fe1
to
e4ba02a
Compare
stevepolitodesign
added a commit
that referenced
this pull request
May 10, 2024
Uses the [bundler-audit][] gem to update the local security database and show any relevant issues with the app's dependencies. This generator is only responsible for installing the gem and adding the Rake task. The [original implementation][] was written in 2014, and is no longer relevant. This is because the gem ships [with a Rake task][] that can be set as the default task, which will be addressed in #1144 Also exposes `backup_file` and `restore_file` test helpers into the public API. [bundler-audit]: https://github.com/rubysec/bundler-audit [original implementation]: e23157e [with a Rake task]: https://github.com/rubysec/bundler-audit#rake-tasks
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the bundler-audit gem to update the local security database and
show any relevant issues with the app's dependencies. This generator is
only responsible for installing the gem.
The original implementation was written in 2014, and is no longer
relevant. This is because the gem ships with a Rake task that can be
set as the default task, which will be addressed in #1144
Also exposes
backup_fileandrestore_filetest helpers into thepublic API.