-
-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add arm64-darwin-22 platform to Gemfile.lock #1142
Add arm64-darwin-22 platform to Gemfile.lock #1142
Conversation
Gemfile.lock
Outdated
@@ -231,6 +231,7 @@ GEM | |||
|
|||
PLATFORMS | |||
arm64-darwin-21 | |||
arm64-darwin-22 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just out of curiosity, what was the inspiration for this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running bundle install
adds this line. I had the same behaviour as Dorian. I think it depends on the macOS version and/or laptop version.
It's a little annoying to have to skip this change when you commit any other gem change, so we decided to add the platform.
I think there's a way to avoid all of this by adding a more generic ruby
platform.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed: if I manually change the platforms list to the following, bundle install
does not modify it.
PLATFORMS
ruby
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for debugging that. Do you think it's worth just setting the PLATFORMS
to ruby
then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do that. It will reduce churn.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated it to just ruby, makes sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I tested this locally by removing Gemfile.lock
and running bin/setup
and then running bundle exec rake
. Everything still works.
No description provided.