Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arm64-darwin-22 platform to Gemfile.lock #1142

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

dorianmarie
Copy link

No description provided.

Gemfile.lock Outdated
@@ -231,6 +231,7 @@ GEM

PLATFORMS
arm64-darwin-21
arm64-darwin-22
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity, what was the inspiration for this change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running bundle install adds this line. I had the same behaviour as Dorian. I think it depends on the macOS version and/or laptop version.

It's a little annoying to have to skip this change when you commit any other gem change, so we decided to add the platform.

I think there's a way to avoid all of this by adding a more generic ruby platform.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed: if I manually change the platforms list to the following, bundle install does not modify it.

PLATFORMS
  ruby

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for debugging that. Do you think it's worth just setting the PLATFORMS to ruby then?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do that. It will reduce churn.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated it to just ruby, makes sense

Copy link
Contributor

@stevepolitodesign stevepolitodesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I tested this locally by removing Gemfile.lock and running bin/setup and then running bundle exec rake. Everything still works.

@dorianmarie dorianmarie merged commit 04ea752 into suspenders-3-0-0 Nov 14, 2023
2 checks passed
@dorianmarie dorianmarie deleted the suspenders-3-gemfile-lock-darwin-22 branch November 14, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants