Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Cleanup: Refactor tests to use helper #1188

Merged
merged 2 commits into from
Apr 13, 2024
Merged

Test Cleanup: Refactor tests to use helper #1188

merged 2 commits into from
Apr 13, 2024

Conversation

stevepolitodesign
Copy link
Contributor

Use with_test_suite helper to clean up existing test setup. This was more relevant when exploring #1156, but is still helpful for generators that are test suite agnostic.

Also cleans up test setup by using a file_fixture that was missed in #1183

@stevepolitodesign
Test Cleanup: Refactor tests to use helper
bd86f47 
Use `with_test_suite` helper to clean up existing test setup. This was
more relevant when exploring #1156, but is still helpful for generators
that are test suite agnostic.

Also cleans up test setup by using a `file_fixture` that was missed in #1183
@stevepolitodesign stevepolitodesign merged commit c694b2a into suspenders-3-0-0 Apr 13, 2024
2 checks passed
@stevepolitodesign stevepolitodesign deleted the suspenders-3-0-0-test-cleanup branch April 13, 2024 15:12
stevepolitodesign added a commit that referenced this pull request May 10, 2024
@stevepolitodesign
Test Cleanup: Refactor tests to use helper (#1188)
4b3e041 
Use `with_test_suite` helper to clean up existing test setup. This was
more relevant when exploring #1156, but is still helpful for generators
that are test suite agnostic.

Also cleans up test setup by using a `file_fixture` that was missed in #1183
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagoa thiagoa Awaiting requested review from thiagoa thiagoa is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@stevepolitodesign