Single test for sign/in out

thunderbird · Dec 13, 2024 · 3c9b934 · 3c9b934
1 parent c5e68c3
commit 3c9b934
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 40 deletions.
diff --git a/test/e2e/browserstack.yml b/test/e2e/browserstack.yml
@@ -29,8 +29,8 @@ platforms:
     osVersion: Sequoia
     browserName: playwright-firefox
     browserVersion: latest
-  - os: Windows
-    osVersion: 11
+  - os: OS X
+    osVersion: Sequoia
     browserName: playwright-chromium
     browserVersion: latest
 

diff --git a/test/e2e/pages/dashboard-page.ts b/test/e2e/pages/dashboard-page.ts
@@ -6,15 +6,17 @@ export class DashboardPage {
   readonly navBarDashboardBtn: Locator;
   readonly userMenuAvatar: Locator;
   readonly logOutMenuItem: Locator;
+  readonly shareMyLink: Locator;
 
   constructor(page: Page) {
     this.page = page;
     this.navBarDashboardBtn = this.page.getByRole('link', { name: 'Dashboard' });
     this.userMenuAvatar = this.page.getByTestId('user-menu-avatar');
     this.logOutMenuItem = this.page.getByTestId('user-nav-logout-menu');
+    this.shareMyLink = this.page.getByTestId('dashboard-share-quick-link-btn');
   }
 
-  async logOut() {
+  async signOut() {
     await expect(this.userMenuAvatar).toBeVisible();
     await this.userMenuAvatar.click();
     await expect(this.logOutMenuItem).toBeVisible();

diff --git a/test/e2e/playwright.config.ts b/test/e2e/playwright.config.ts
@@ -21,6 +21,8 @@ export default defineConfig({
   retries: process.env.CI ? 2 : 0,
   /* Opt out of parallel tests on CI. */
   workers: process.env.CI ? 1 : 1, // actualy don't run in parallel locally either, for now
+  // Tests will timeout if still running after this time (ms)
+  timeout: 3 * 60 * 1000,
   /* Reporter to use. See https://playwright.dev/docs/test-reporters */
   reporter: [['list']],
   /* Shared settings for all the projects below. See https://playwright.dev/docs/api/class-testoptions. */

diff --git a/test/e2e/tests/sign-in.spec.ts b/test/e2e/tests/sign-in.spec.ts
@@ -17,17 +17,22 @@ test.beforeEach(async ({ page }) => {
 });
 
 // verify basic sign-in flow works
-test.describe('sign-in flow', {
+test.describe('sign-in and sign-out flow', {
   tag: '@prod-sanity'
 }, () => {
-  test('able to sign-in to appointment via fxa', async ({ page }) => {
+  test('able to sign-in and out of appointment via fxa', async ({ page }) => {
     await splashscreen.getToFxA();
-    await expect(fxa_sign_in.signInHeaderText).toBeVisible({ timeout: 30_000 });
-    await expect(fxa_sign_in.userAvatar).toBeVisible({ timeout: 30_000}); // generous time for fxa to appear
+    await expect(fxa_sign_in.signInHeaderText).toBeVisible({ timeout: 30_000 }); // generous time for fxa to appear
+    await expect(fxa_sign_in.userAvatar).toBeVisible({ timeout: 30_000});
     await expect(fxa_sign_in.signInButton).toBeVisible();
     await fxa_sign_in.signIn();
-    await expect(page).toHaveTitle(APPT_PAGE_TITLE, { timeout: 30_000 }); // give generous time for fxa sign to complete
+    await expect(page).toHaveTitle(APPT_PAGE_TITLE, { timeout: 30_000 }); // give generous time for fxa sign-in
     await expect(dashboard_page.userMenuAvatar).toBeVisible({ timeout: 30_000 });
     await expect(dashboard_page.navBarDashboardBtn).toBeVisible({ timeout: 30_000 });
+    await expect(dashboard_page.shareMyLink).toBeVisible({ timeout: 30_000 });
+    await page.waitForLoadState('domcontentloaded');
+    await dashboard_page.signOut();
+    await expect(page).toHaveTitle(APPT_PAGE_TITLE, { timeout: 30_000 }); // generous time for fxa sign-out
+    await expect(splashscreen.loginBtn).toBeVisible({ timeout: 30_000 });
   });
 });
diff --git a/test/e2e/tests/sign-out.spec.ts b/test/e2e/tests/sign-out.spec.ts