-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation and get rid of serialize-only Message type #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leftmostcat
commented
Oct 28, 2024
leftmostcat
commented
Oct 28, 2024
leftmostcat
commented
Oct 28, 2024
leftmostcat
commented
Oct 28, 2024
leftmostcat
commented
Oct 28, 2024
leftmostcat
commented
Oct 28, 2024
leftmostcat
commented
Oct 28, 2024
leftmostcat
commented
Oct 28, 2024
leftmostcat
commented
Oct 28, 2024
leftmostcat
commented
Oct 28, 2024
tobypilling
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. Love this forward thinking on the other uses for Updates
tobypilling
added a commit
that referenced
this pull request
Oct 31, 2024
* Created UpdateItem and added necessary trait implementations * Respond to feedback on UpdateItem, unduplicate MessageDisposition (now as Option<MessageDisposition>) and add Clone for all types * Also added default trait for ConflictResolution * Adjusted comment to use a noun phrase for ConflictResolution * Fixed formatting issues * Test formatting * Fix formatting again * Test broken formatting * Test broken formatting * Fix broken formatting * Update documentation and get rid of serialize-only Message type (#23) * Add reference to EWS updateitem docs --------- Co-authored-by: Sean Burke <[email protected]>
babolivier
added a commit
that referenced
this pull request
Nov 14, 2024
#23 updated CreateItem to use the same Message type for both serialization and deserialization. However, it did not add the attributes that xml-struct-rs uses to correctly include the prefix for the t/types namespace on relevant tags. This change updates all of the fields under Message, so future developments aren't bitten by this error. According to https://learn.microsoft.com/en-us/exchange/client-developer/web-service-reference/createitem-operation-email-message#createitem-request-example, both the Message and its children need the t prefix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposes a series of updates to Toby's PR at #18 to more rapidly illustrate what I'm expecting.