Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation and get rid of serialize-only Message type #23

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

leftmostcat
Copy link
Collaborator

This proposes a series of updates to Toby's PR at #18 to more rapidly illustrate what I'm expecting.

Copy link
Collaborator

@tobypilling tobypilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Love this forward thinking on the other uses for Updates

@tobypilling tobypilling merged commit 483be7c into tobypilling/update_item Oct 29, 2024
@tobypilling tobypilling deleted the update-item-revisions branch October 29, 2024 16:47
tobypilling added a commit that referenced this pull request Oct 31, 2024
* Created UpdateItem and added necessary trait implementations

* Respond to feedback on UpdateItem, unduplicate MessageDisposition (now as Option<MessageDisposition>) and add Clone for all types

* Also added default trait for ConflictResolution

* Adjusted comment to use a noun phrase for ConflictResolution

* Fixed formatting issues

* Test formatting

* Fix formatting again

* Test broken formatting

* Test broken formatting

* Fix broken formatting

* Update documentation and get rid of serialize-only Message type (#23)

* Add reference to EWS updateitem docs

---------

Co-authored-by: Sean Burke <[email protected]>
babolivier added a commit that referenced this pull request Nov 14, 2024
#23 updated CreateItem to use the same Message type for both serialization and deserialization. However, it did not add the attributes that xml-struct-rs uses to correctly include the prefix for the t/types namespace on relevant tags.

This change updates all of the fields under Message, so future developments aren't bitten by this error.

According to https://learn.microsoft.com/en-us/exchange/client-developer/web-service-reference/createitem-operation-email-message#createitem-request-example, both the Message and its children need the t prefix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants