Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support XML serialization for UpdateItem #27

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

tobypilling
Copy link
Collaborator

I made some changes to support the serialization. If you don't like the enum approach, could you play around and see if there's a better way? I'll put up the changes in c-c so you can bring both down to play.

@babolivier babolivier changed the title Changes to support XML serialization Support XML serialization for UpdateItem Nov 12, 2024
src/types/update_item.rs Outdated Show resolved Hide resolved
src/types/update_item.rs Outdated Show resolved Hide resolved
Copy link
Member

@babolivier babolivier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! At some point we probably should consider doing similar changes to Updates as we did for ItemChanges but that's probably out of scope for now.

@tobypilling tobypilling merged commit a801098 into main Nov 13, 2024
2 checks passed
@tobypilling tobypilling deleted the tobypilling/update_item_changes branch November 13, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants