Correct Folder namespaces and CreateFolderResponse structure #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leftmostcat
commented
Dec 2, 2024
Comment on lines
+826
to
830
| #[xml_struct(ns_prefix = "t")] | ||
| total_count: Option<u32>, | ||
|
|
||
| #[xml_struct(ns_prefix = "t")] | ||
| child_folder_count: Option<u32>, |
There was a problem hiding this comment.
Prefixing total_count and child_folder_count (as well as unread_count for Folder) is a bit weird since they're explicitly read-only and we should never actually be sending them, but I think it's better to do so, as we might get a specific "these fields are read-only" error instead of the generic 500 we get when we don't specify namespaces correctly.
|
I've verified that I can successfully create a folder remotely and handle the response with these changes in place. |
babolivier
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serialization of
CreateFolderand deserialization ofCreateFolderResponsewere incorrect due to unspecified namespace prefixes on theFolderenum and use of the incorrect type in the response struct.