Use custom {de,}serialization for operation/response envelopes #5
Conversation
This allows for creating a strongly-typed link between an operation and its associated response, rather than forcing consumers to match on enums when only a single variant is possible without error.
| where | ||
| A: serde::de::MapAccess<'de>, | ||
| { | ||
| match map.next_key::<String>()? { |
There was a problem hiding this comment.
As far as I know, we should never be receiving more than one element in the body of a response. That said, there's no documented guarantee of this that I'm aware of, so this code could potentially be made more robust by iterating next_key() until it gave us None and deserializing the expected body if we find it, logging any unexpected elements, and erroring if we never find it. Would appreciate thoughts on this.
There was a problem hiding this comment.
As far as I understood the the documentation the inner body response is considered a collection?
There was a problem hiding this comment.
A quick scan through the WSDL suggests that the contents of the soap:Body will always be exactly one element.
| pub trait EnvelopeBodyContents { | ||
| /// Gets the name of the element enclosing the contents of this | ||
| /// structure when represented in XML. | ||
| fn name() -> &'static str; |
There was a problem hiding this comment.
Deriving this would be pretty trivial and we probably want to do that soon. I just wanted to get it working.
For derivation, we could even potentially make it so that Operation and OperationResponse are the traits used for the macro(s) and getting EnvelopeBodyContents is a "hidden" bonus. It would just require that we add something like a #[response(GetFolderResponse)] attribute to the Operation derive. Thoughts on this are welcomed.
There was a problem hiding this comment.
Perhaps something more specific to the project such as #[ews:node(GetFolderResponse)] ?
There was a problem hiding this comment.
I believe the helper attribute needs to be a valid identifier, but that's something we can figure out later if we do want to add this derive functionality in that form.
|
Merged. |
This allows for creating a strongly-typed link between an operation and its associated response, rather than forcing consumers to match on enums when only a single variant is possible without error.