Better readme #50
Merged
Better readme #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LouisJULIEN
force-pushed
the
better_readme
branch
2 times, most recently
from
c93ab35 to
185d68d
Compare
|
Superb, thanks. Let me know how things go with the calendar API, I'd love to get this into core eventually. |
kewisch
requested changes
Nov 29, 2024
.gitignore
Outdated
| @@ -1,3 +1,4 @@ | |||
| **/web-ext-artifacts | |||
| **/*.xpi | |||
| node_modules | |||
| .idea/ | |||
There was a problem hiding this comment.
Ah can you remove this? If this is an issue it should probably rather go into your ~/.gitignore_global
There was a problem hiding this comment.
Not really an issue, I'm reverting that!
There was a problem hiding this comment.
And thanks for the gitignore_global tip
LouisJULIEN
force-pushed
the
better_readme
branch
from
185d68d to
5208f46
Compare
kewisch
approved these changes
Nov 29, 2024
|
Needs a review/rubber stamp from @jobisoft as well. |
jobisoft
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found it super confusing to find out how to use the calendar experiment based on the Readme (calendar/README.md) most links redirect to. I added a few words to help.