forked from tikv/pd
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This is an automated cherry-pick of tikv#8877
close tikv#8876 Signed-off-by: ti-chi-bot <[email protected]>
- Loading branch information
1 parent
d347eed
commit 06c5c42
Showing
10 changed files
with
367 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| // Copyright 2020 The Go Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style | ||
| // license that can be found in the LICENSE file. | ||
|
|
||
| // Note: This file is copied from https://go-review.googlesource.com/c/go/+/276133 | ||
|
|
||
| package timerutil | ||
|
|
||
| import ( | ||
| "sync" | ||
| "time" | ||
| ) | ||
|
|
||
| // GlobalTimerPool is a global pool for reusing *time.Timer. | ||
| var GlobalTimerPool TimerPool | ||
|
|
||
| // TimerPool is a wrapper of sync.Pool which caches *time.Timer for reuse. | ||
| type TimerPool struct { | ||
| pool sync.Pool | ||
| } | ||
|
|
||
| // Get returns a timer with a given duration. | ||
| func (tp *TimerPool) Get(d time.Duration) *time.Timer { | ||
| if v := tp.pool.Get(); v != nil { | ||
| timer := v.(*time.Timer) | ||
| timer.Reset(d) | ||
| return timer | ||
| } | ||
| return time.NewTimer(d) | ||
| } | ||
|
|
||
| // Put tries to call timer.Stop() before putting it back into pool, | ||
| // if the timer.Stop() returns false (it has either already expired or been stopped), | ||
| // have a shot at draining the channel with residual time if there is one. | ||
| func (tp *TimerPool) Put(timer *time.Timer) { | ||
| if !timer.Stop() { | ||
| select { | ||
| case <-timer.C: | ||
| default: | ||
| } | ||
| } | ||
| tp.pool.Put(timer) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| // Copyright 2020 The Go Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style | ||
| // license that can be found in the LICENSE file. | ||
|
|
||
| // Note: This file is copied from https://go-review.googlesource.com/c/go/+/276133 | ||
|
|
||
| package timerutil | ||
|
|
||
| import ( | ||
| "testing" | ||
| "time" | ||
| ) | ||
|
|
||
| func TestTimerPool(t *testing.T) { | ||
| var tp TimerPool | ||
|
|
||
| for i := 0; i < 100; i++ { | ||
| timer := tp.Get(20 * time.Millisecond) | ||
|
|
||
| select { | ||
| case <-timer.C: | ||
| t.Errorf("timer expired too early") | ||
| continue | ||
| default: | ||
| } | ||
|
|
||
| select { | ||
| case <-time.After(100 * time.Millisecond): | ||
| t.Errorf("timer didn't expire on time") | ||
| case <-timer.C: | ||
| } | ||
|
|
||
| tp.Put(timer) | ||
| } | ||
| } | ||
|
|
||
| const timeout = 10 * time.Millisecond | ||
|
|
||
| func BenchmarkTimerUtilization(b *testing.B) { | ||
| b.Run("TimerWithPool", func(b *testing.B) { | ||
| for i := 0; i < b.N; i++ { | ||
| t := GlobalTimerPool.Get(timeout) | ||
| GlobalTimerPool.Put(t) | ||
| } | ||
| }) | ||
| b.Run("TimerWithoutPool", func(b *testing.B) { | ||
| for i := 0; i < b.N; i++ { | ||
| t := time.NewTimer(timeout) | ||
| t.Stop() | ||
| } | ||
| }) | ||
| } | ||
|
|
||
| func BenchmarkTimerPoolParallel(b *testing.B) { | ||
| b.RunParallel(func(pb *testing.PB) { | ||
| for pb.Next() { | ||
| t := GlobalTimerPool.Get(timeout) | ||
| GlobalTimerPool.Put(t) | ||
| } | ||
| }) | ||
| } | ||
|
|
||
| func BenchmarkTimerNativeParallel(b *testing.B) { | ||
| b.RunParallel(func(pb *testing.PB) { | ||
| for pb.Next() { | ||
| t := time.NewTimer(timeout) | ||
| t.Stop() | ||
| } | ||
| }) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| // Copyright 2024 TiKV Project Authors. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package timerutil | ||
|
|
||
| import "time" | ||
|
|
||
| // SafeResetTimer is used to reset timer safely. | ||
| // Before Go 1.23, the only safe way to use Reset was to call Timer.Stop and explicitly drain the timer first. | ||
| // We need be careful here, see more details in the comments of Timer.Reset. | ||
| // https://pkg.go.dev/time@master#Timer.Reset | ||
| func SafeResetTimer(t *time.Timer, d time.Duration) { | ||
| // Stop the timer if it's not stopped. | ||
| if !t.Stop() { | ||
| select { | ||
| case <-t.C: // try to drain from the channel | ||
| default: | ||
| } | ||
| } | ||
| t.Reset(d) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| // Copyright 2020 The Go Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style | ||
| // license that can be found in the LICENSE file. | ||
|
|
||
| // Note: This file is copied from https://go-review.googlesource.com/c/go/+/276133 | ||
|
|
||
| package timerutil | ||
|
|
||
| import ( | ||
| "sync" | ||
| "time" | ||
| ) | ||
|
|
||
| // GlobalTimerPool is a global pool for reusing *time.Timer. | ||
| var GlobalTimerPool TimerPool | ||
|
|
||
| // TimerPool is a wrapper of sync.Pool which caches *time.Timer for reuse. | ||
| type TimerPool struct { | ||
| pool sync.Pool | ||
| } | ||
|
|
||
| // Get returns a timer with a given duration. | ||
| func (tp *TimerPool) Get(d time.Duration) *time.Timer { | ||
| if v := tp.pool.Get(); v != nil { | ||
| timer := v.(*time.Timer) | ||
| timer.Reset(d) | ||
| return timer | ||
| } | ||
| return time.NewTimer(d) | ||
| } | ||
|
|
||
| // Put tries to call timer.Stop() before putting it back into pool, | ||
| // if the timer.Stop() returns false (it has either already expired or been stopped), | ||
| // have a shot at draining the channel with residual time if there is one. | ||
| func (tp *TimerPool) Put(timer *time.Timer) { | ||
| if !timer.Stop() { | ||
| select { | ||
| case <-timer.C: | ||
| default: | ||
| } | ||
| } | ||
| tp.pool.Put(timer) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| // Copyright 2020 The Go Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style | ||
| // license that can be found in the LICENSE file. | ||
|
|
||
| // Note: This file is copied from https://go-review.googlesource.com/c/go/+/276133 | ||
|
|
||
| package timerutil | ||
|
|
||
| import ( | ||
| "testing" | ||
| "time" | ||
| ) | ||
|
|
||
| func TestTimerPool(t *testing.T) { | ||
| var tp TimerPool | ||
|
|
||
| for i := 0; i < 100; i++ { | ||
| timer := tp.Get(20 * time.Millisecond) | ||
|
|
||
| select { | ||
| case <-timer.C: | ||
| t.Errorf("timer expired too early") | ||
| continue | ||
| default: | ||
| } | ||
|
|
||
| select { | ||
| case <-time.After(100 * time.Millisecond): | ||
| t.Errorf("timer didn't expire on time") | ||
| case <-timer.C: | ||
| } | ||
|
|
||
| tp.Put(timer) | ||
| } | ||
| } | ||
|
|
||
| const timeout = 10 * time.Millisecond | ||
|
|
||
| func BenchmarkTimerUtilization(b *testing.B) { | ||
| b.Run("TimerWithPool", func(b *testing.B) { | ||
| for i := 0; i < b.N; i++ { | ||
| t := GlobalTimerPool.Get(timeout) | ||
| GlobalTimerPool.Put(t) | ||
| } | ||
| }) | ||
| b.Run("TimerWithoutPool", func(b *testing.B) { | ||
| for i := 0; i < b.N; i++ { | ||
| t := time.NewTimer(timeout) | ||
| t.Stop() | ||
| } | ||
| }) | ||
| } | ||
|
|
||
| func BenchmarkTimerPoolParallel(b *testing.B) { | ||
| b.RunParallel(func(pb *testing.PB) { | ||
| for pb.Next() { | ||
| t := GlobalTimerPool.Get(timeout) | ||
| GlobalTimerPool.Put(t) | ||
| } | ||
| }) | ||
| } | ||
|
|
||
| func BenchmarkTimerNativeParallel(b *testing.B) { | ||
| b.RunParallel(func(pb *testing.PB) { | ||
| for pb.Next() { | ||
| t := time.NewTimer(timeout) | ||
| t.Stop() | ||
| } | ||
| }) | ||
| } |
Oops, something went wrong.