Introduce CAN timing adjustments as snippet and rework complete test strategy #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rexut
force-pushed
the
devel/tests/alt-config
branch
from
6973655 to
6166d04
Compare
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
Deprecate the (Re-)Synchronization Jump Width (SJW) devicetree properties for both arbitration and data phase timing as these are now only used in combination with the other TQ-based CAN timing properties, which are all deprecated. Related to upstream changes: - zephyrproject-rtos/zephyr#63034 Signed-off-by: Stephan Linz <[email protected]>
Some systems needs reduced bus speeds to pass Zephyr's standard CAN test suite successfully. Signed-off-by: Stephan Linz <[email protected]>
This reverts commit ad49608. Since the beginning, the adjustments of the CAN timing for board TiaC Magpie STM32F777NIHx as a shield was more a workaround than a clean and correct abstraction of this problem. With introduction of snippets as part of the Zephyr build process, this way over a shield can now be abandoned and the general-purpose snippet 'can-timing-adj' have to be used instead. Signed-off-by: Stephan Linz <[email protected]>
rexut
force-pushed
the
devel/tests/alt-config
branch
from
6166d04 to
8f3b27a
Compare
With this alternative configuration the downstream board 'tiac_magpie' will be sopported by the Zephyr upstream can test suite. Signed-off-by: Stephan Linz <[email protected]>
With this alternative configuration the downstream board 'tiac_magpie' will be sopported by the Zephyr upstream watchdog test suite. Signed-off-by: Stephan Linz <[email protected]>
This reverts commit bd2ff4e. This reverts commit 637267c. This reverts commit e7efc40. Since Twister understands alternative test spec configuration, the "clone and own" strategy can be abandoned. Signed-off-by: Stephan Linz <[email protected]>
With this alternative configuration the downstream board 'tiac_magpie' will be sopported by the Zephyr upstream i2c test suite. Signed-off-by: Stephan Linz <[email protected]>
This reverts commit 3d3a3d3. This reverts commit a2eeded, also remove 'boards/shields/loopback_test/tests/i2c_slave_api.defconfig'. Since Twister understands alternative test spec configuration, the "clone and own" strategy can be abandoned. Signed-off-by: Stephan Linz <[email protected]>
Signed-off-by: Stephan Linz <[email protected]>
Signed-off-by: Stephan Linz <[email protected]>
Signed-off-by: Stephan Linz <[email protected]>
Signed-off-by: Stephan Linz <[email protected]>
rexut
force-pushed
the
devel/tests/alt-config
branch
from
8f3b27a to
c844acf
Compare
tobiaskaestner
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #127 this convert the old
can_timing_adjshield to the newcan-timing-adjsnipped with same functionality and bind to the new snipped when calling Zephyr test suites from upstream with tweaked test case configuration from Bridle downstream.