Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test infrastructure in v3.5 release branch #153

Merged
merged 31 commits into from
Nov 10, 2023
Merged

Improve test infrastructure in v3.5 release branch #153

merged 31 commits into from
Nov 10, 2023

Conversation

rexut
Copy link
Member

@rexut rexut commented Nov 9, 2023 •
edited by tobiaskaestner
Loading

This fulfills Issues #151 and #152 with following improvements:

  • All tests for Grove Interconnect, Button, and LED Shields converted to be more generic and guided by a list of well-known integration platforms currently supported by Bridle. This leads to a super-matrix of test suites and test cases and thus all invalid board/shield conditions which are either unsupported or have unfinished implementations are now excluded by the new global quarantine list in tests/quarantine.yaml.
  • All SAMD21 targets don't yet support the LED shell command against the internal LED driver API properly in case of mixed GPIO and PWM LEDs on same I/O pin (shared pin function), thus related CONFIG_LED and CONFIG_LED_SHELL were disable for this boards as default.
  • The Grove Interconnect Shield demonstration has been expanded to also include the Raspberry Pi Pico W and Waveshare RP2040-LCD-0.96 boards on the Grove Shield for Pi Pico V1.
  • In conjunction with the new Twister upstream support for filtering tests by board manufacturer or vendor, Bridle now also provides the vendor entry for each supported board.

rexut added 10 commits November 6, 2023 08:48
@rexut
tests: grove: base: set Seeeduino equal to Arduino Zero
0a46564 
Signed-off-by: Stephan Linz <[email protected]>
@rexut
tests: grove: btn: set Seeeduino equal to Arduino Zero
31d9534 
Signed-off-by: Stephan Linz <[email protected]>
@rexut
tests: grove: led: set Seeeduino equal to Arduino Zero
3abd460 
Signed-off-by: Stephan Linz <[email protected]>
@rexut
boards: seeeduino_lotus: expand Grove PWM mapping
ad80094 
Signed-off-by: Stephan Linz <[email protected]>
@rexut
boards: seeeduino_cm0: expand Grove PWM mapping
d700bf6 
Signed-off-by: Stephan Linz <[email protected]>
@rexut
shields: grove: set Seeeduino equal to Arduino Zero
48d0abc 
Signed-off-by: Stephan Linz <[email protected]>
@rexut
boards: arm: seeed_xiao_samd21: add XIAO DAC feature
eec2f6c 
For better testcase filter by 'depends_on' the board must provide
the supported DAC feature on XIAO connector.

Signed-off-by: Stephan Linz <[email protected]>
@rexut
shields: grove: set all RPi Pico based boards equal
a03109a 
Signed-off-by: Stephan Linz <[email protected]>
@rexut
boards: waveshare_rp2040: add RPi Pico features
3d5f645 
For better testcase filter by 'depends_on' the board must provide
all supported RPi Pico connector features.

Signed-off-by: Stephan Linz <[email protected]>
@rexut
tests: add global quarantine list
0366154 
This global quarantine list defines all valid exclusion
constraints of the upcoming supertest matrix for all
integration platforms supported by Bridle in one place.

Signed-off-by: Stephan Linz <[email protected]>
@rexut rexut self-assigned this Nov 9, 2023
@rexut rexut added this to the v3.5.1 milestone Nov 9, 2023
rexut added 9 commits November 9, 2023 23:06
@rexut
tests: grove: base: use integration platform tests
9542e94 
Together with the new global quarantine list all specific
test cases are now more generic and independent of special
white or black lists. When ever an exclusion will be needed
this rule have to add to the new global quarantine list.

Signed-off-by: Stephan Linz <[email protected]>
@rexut
tests: grove: btn: use integration platform tests
3c80d9c 
Together with the new global quarantine list all specific
test cases are now more generic and independent of special
white or black lists. When ever an exclusion will be needed
this rule have to add to the new global quarantine list.

Signed-off-by: Stephan Linz <[email protected]>
@rexut
tests: grove: led: use integration platform tests
ebdc368 
Together with the new global quarantine list all specific
test cases are now more generic and independent of special
white or black lists. When ever an exclusion will be needed
this rule have to add to the new global quarantine list.

Signed-off-by: Stephan Linz <[email protected]>
@rexut
tests: x_grove_testbed: use integration platform tests
272bbfd 
Together with the new global quarantine list all specific
test cases are now more generic and independent of special
white or black lists. When ever an exclusion will be needed
this rule have to add to the new global quarantine list.

In addition, the "Grove Base V2" shield constellation
is also being tested on the Seeed Studio Lotus board.

Signed-off-by: Stephan Linz <[email protected]>
@rexut
shield: x_grove_testbed: avoid duplicate code
bb7d8d6 
Signed-off-by: Stephan Linz <[email protected]>
@rexut
doc: shields: grove: nucleo_f413zh: add PWM mapping
8ff2ab2 
Signed-off-by: Stephan Linz <[email protected]>
@rexut
boards: seeeduino_lotus: add label grove_pwm_d8 in DTS
f6b7ecf 
Signed-off-by: Stephan Linz <[email protected]>
@rexut
samples: helloshell: add RPi Pico (W) for integration
8ba9f6c 
Signed-off-by: Stephan Linz <[email protected]>
@rexut
samples: helloshell: add WS RP4020 Plus for integration
313bf1a 
Signed-off-by: Stephan Linz <[email protected]>
rexut added 12 commits November 9, 2023 23:06
@rexut
tests: x_grove_testbed: support RPi Pico W
c4591ad 
Signed-off-by: Stephan Linz <[email protected]>
@rexut
shield: x_grove_testbed: add RPi Pico W
64ef36d 
Signed-off-by: Stephan Linz <[email protected]>
@rexut
tests: x_grove_testbed: support WS RP2040-LCD-0.96
e948c29 
Signed-off-by: Stephan Linz <[email protected]>
@rexut
shield: x_grove_testbed: add WS RP2040-LCD-0.96
249bea8 
Signed-off-by: Stephan Linz <[email protected]>
@rexut
shields: grove: restruct RPi Pico shield interface
7e27bfe 
Signed-off-by: Stephan Linz <[email protected]>
@rexut
shields: grove: set Nucleo F413ZH equal to F767ZI
8c51096 
Signed-off-by: Stephan Linz <[email protected]>
@rexut
shields: grove: add note on additional resistores
e2677d9 
Signed-off-by: Stephan Linz <[email protected]>
@rexut
shields: grove: fix typos in comments
87ae14f 
Signed-off-by: Stephan Linz <[email protected]>
@rexut
dts: vendor-prefixes: update entries
49fe7be 
- add new prefix 'nxp'
- add new prefix 'tiac'
- add new prefix 'waveshare'
- fix full name of prefix 'st'

Signed-off-by: Stephan Linz <[email protected]>
@rexut
boards: add vendor to board yaml
2e303ed 
In conjunction with the new Twister upstream support for
filtering tests by board manufacturer or vendor, Bridle
now also provides the vendor entry for each supported board.

Signed-off-by: Stephan Linz <[email protected]>
@rexut
release: update draft notes for upcoming 3.5.1
77e171e 
Signed-off-by: Stephan Linz <[email protected]>
@rexut
ci: github: qa-integration: use integration platforms
5dfe541 
Signed-off-by: Stephan Linz <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@rexut rexut requested a review from tobiaskaestner November 10, 2023 13:02
tobiaskaestner
tobiaskaestner approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@tobiaskaestner tobiaskaestner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, many thanks

tests/quarantine.yaml
# Grove wiring for tests
#

- comment: "shield(x_grove_testbed): (yet) completely unsupported platform."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: (yet) -> (currently)

@rexut rexut merged commit 5dfe541 into v3.5-branch Nov 10, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiaskaestner tobiaskaestner tobiaskaestner approved these changes

Assignees

@rexut rexut

Labels
area: Boards area: Devicetree Binding area: Devicetree area: Documentation area: Release Notes area: Samples area: Shields area: Tests platform: RPi
Projects
None yet
Milestone
v3.5.1
Development

Successfully merging this pull request may close these issues.
2 participants
@rexut @tobiaskaestner