Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix many failed integration tests on Bridles main HIL infrastructure #230

Merged
merged 9 commits into from
Jun 10, 2024

Conversation

rexut
Copy link
Member

@rexut rexut commented Jun 9, 2024

This fixes #229 & fixes #231

Since Zephyr upstrem PR 73654 CAN controller bus-speed is deprecated,
rename them to bitrate to match the terminology used in other CAN
devicetree properties and the CAN subsystem API.

Signed-off-by: Stephan Linz <[email protected]>
tobiaskaestner
tobiaskaestner previously approved these changes Jun 9, 2024
Copy link
Contributor

@tobiaskaestner tobiaskaestner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rexut added 3 commits June 10, 2024 00:22
Some systems needs reduced bus speeds to pass Zephyr's
standard watchdog test suite successfully.

Signed-off-by: Stephan Linz <[email protected]>
Using the new snippet “Watchdog timing adjustments” (wdt-timing-adj)
to eliminate the fiddly challenge of the slightly too fast SYSCLK/HCLK
setup on the TiaC Magpie F777NI board.

Signed-off-by: Stephan Linz <[email protected]>
A larger timeout setting does not show the desired behavior in the
Bridle HIL infrastructure. The race conditions between different test
cases still exist. It can probably only be eliminated by avoiding
parallel twister jobs, not by increasing waiting times.

Signed-off-by: Stephan Linz <[email protected]>
Reduce Twister parallel jobs to a minimum. All test cases should be
processed sequentially one after the other to avoid race conditions.
With two jobs in parallel, one job will build a test suite the other
job will execute on target and pick up results.

Signed-off-by: Stephan Linz <[email protected]>
rexut added 4 commits June 10, 2024 08:13
The Pytest plugin `pytest-twister-harness` in Zephyr upstream
has been enhanced with the new auxiliary module `domains_helper`.
This is explicitly dependent on setting the environment variable
`ZEPHYR_BASE`. Since Bridle regards this variable as optional,
building the documentation set Zephyr fails. Bridle therefore
only sets this variable within the Sphinx runtime environment
in order to perform the automatic import of the relevant Pytest
plugin by the Sphinx extension `autodoc` without errors.

Signed-off-by: Stephan Linz <[email protected]>
Obsolete exclusions removed.

Signed-off-by: Stephan Linz <[email protected]>
Obsolete exclusions removed.

Signed-off-by: Stephan Linz <[email protected]>
Add the new snippet for watchdog timing adjustments (wdt-timing-adj).
Export ZEPHYR_BASE as environment variable to make autodoc happy.

Signed-off-by: Stephan Linz <[email protected]>
Copy link

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@rexut rexut requested a review from tobiaskaestner June 10, 2024 08:49
@rexut
Copy link
Member Author

rexut commented Jun 10, 2024

LGTM

@tobiaskaestner: Unfortunately, there was a second BUG #231 and your review is needed again.

Copy link
Contributor

@Irockasingranite Irockasingranite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rexut rexut merged commit 3e6fffa into main Jun 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] build Zephyr docset fails [BUG] magpie_f777ni: wdt_basic_api/drivers.watchdog.stm32wwdg FAILED
3 participants