-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more Raspberry Pi Pico LCD Shields #238
Conversation
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
Found the new shields here: https://bridle.tiac-systems.net/ghpr/doc/PR-238/bridle/boards/shields/rpi_pico_lcd/doc/index.html |
boards/shields/rpi_pico_lcd/doc/waveshare_pico_lcd_1_44/positions.rsti
Outdated
Show resolved
Hide resolved
boards/shields/rpi_pico_lcd/boards/waveshare_pico_lcd_0_96/rpipico_r3.dtsi
Outdated
Show resolved
Hide resolved
boards/shields/rpi_pico_lcd/doc/waveshare_pico_lcd_1_8/pinouts.rsti
Outdated
Show resolved
Hide resolved
80628fb
to
3da299b
Compare
CONVERTED TO DRAFT see review comments in PR #243 |
boards/shields/rpi_pico_lcd/doc/waveshare_pico_lcd_1_8/lvgl_basic.rsti
Outdated
Show resolved
Hide resolved
done –> READY FOR REVIEW |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The merge-base changed after approval.
- Waveshare Pico LCD 1.14 - Waveshare Pico LCD 2 Signed-off-by: Stephan Linz <[email protected]>
The new part of the Raspberry Pi Pico LCD shield by Waveshare is: * Pico LCD 0.96 (waveshare_pico_lcd_0_96) supported features: * display API (zephyr/samples/drivers/display) * LVGL stack (zephyr/samples/subsys/display/lvgl) * input API (zephyr/samples/subsys/input/input_dump) supported platforms: * Raspberry Pi Pico (rpi_pico) * Raspberry Pi Pico W (rpi_pico_w) * Waveshare RP2040 Plus 4MB (waveshare_rp2040_plus) * Waveshare RP2040 Plus 16MB (waveshare_rp2040_plus@16mb) Signed-off-by: Stephan Linz <[email protected]>
The new part of the Raspberry Pi Pico LCD shield by Waveshare is: * Pico LCD 1.3 (waveshare_pico_lcd_1_3) supported features: * display API (zephyr/samples/drivers/display) * LVGL stack (zephyr/samples/subsys/display/lvgl) * input API (zephyr/samples/subsys/input/input_dump) supported platforms: * Raspberry Pi Pico (rpi_pico) * Raspberry Pi Pico W (rpi_pico_w) * Waveshare RP2040 Plus 4MB (waveshare_rp2040_plus) * Waveshare RP2040 Plus 16MB (waveshare_rp2040_plus@16mb) Signed-off-by: Stephan Linz <[email protected]>
The new part of the Raspberry Pi Pico LCD shield by Waveshare is: * Pico LCD 1.44 (waveshare_pico_lcd_1_44) supported features: * display API (zephyr/samples/drivers/display) * LVGL stack (zephyr/samples/subsys/display/lvgl) * input API (zephyr/samples/subsys/input/input_dump) supported platforms: * Raspberry Pi Pico (rpi_pico) * Raspberry Pi Pico W (rpi_pico_w) * Waveshare RP2040 Plus 4MB (waveshare_rp2040_plus) * Waveshare RP2040 Plus 16MB (waveshare_rp2040_plus@16mb) Signed-off-by: Stephan Linz <[email protected]>
The new part of the Raspberry Pi Pico LCD shield by Waveshare is: * Pico LCD 1.8 (waveshare_pico_lcd_1_8) supported features: * display API (zephyr/samples/drivers/display) * LVGL stack (zephyr/samples/subsys/display/lvgl) * input API (zephyr/samples/subsys/input/input_dump) supported platforms: * Raspberry Pi Pico (rpi_pico) * Raspberry Pi Pico W (rpi_pico_w) * Waveshare RP2040 Plus 4MB (waveshare_rp2040_plus) * Waveshare RP2040 Plus 16MB (waveshare_rp2040_plus@16mb) Signed-off-by: Stephan Linz <[email protected]>
The new part of the Raspberry Pi Pico LCD shield by Waveshare is: * Pico ResTouch LCD 2.8 (waveshare_pico_restouch_lcd_2_8) supported features: * display API (zephyr/samples/drivers/display) * LVGL stack (zephyr/samples/subsys/display/lvgl) * input API (zephyr/samples/subsys/input/input_dump) supported platforms: * Raspberry Pi Pico (rpi_pico) * Raspberry Pi Pico W (rpi_pico_w) * Waveshare RP2040 Plus 4MB (waveshare_rp2040_plus) * Waveshare RP2040 Plus 16MB (waveshare_rp2040_plus@16mb) Signed-off-by: Stephan Linz <[email protected]>
All supported displays now provide standardized variations for the orientation of the content. The displays always have a preferred orientation, landscape, with the USB port either on the left side or facing upwards. Alternatively, this orientation can be changed to portrait and the following variations can also be applied: - mirrored (flip horizontal, hFlip) - upside down (flip vertical, vFlip) - over head (rotated by 180°) USBD (USBD) --- .----.-^^-.----. .----.--------^^-.----. ^ | rd | | gn | | rd | | gn | | +----´ `----+ +----´ `----+ | | | USBD < landscape | | | +----. .----+ vFlip | portrait | | bk | | bl | | > (USBD) `----'-----------'----´ | | | | +----. ,----+ |<------ hFlip ------>| v | bk | | bl | (mirrored) --- `----'----'----´ (upside down) .---------. .-----. |bl bk| |bl bk| | | < (over head) > | | |gn rd| |gn rd| `---------´ `-----´ Signed-off-by: Stephan Linz <[email protected]>
To improve the clarity of the main page, almost all subsections with detailed information are moved to newly created RST include files in the respective subdirectories. Signed-off-by: Stephan Linz <[email protected]>
All supported displays now provide standardized variations for the orientation of the content. The displays always have a preferred orientation, landscape, with the connector port either on the right side or facing downwards. Alternatively, this orientation can be changed to portrait and the following variations can also be applied: - mirrored (flip horizontal, hFlip) - upside down (flip vertical, vFlip) - over head (rotated by 180°) --- .----.----.----. .----.-----------.----. ^ | rd | | gn | | rd | | gn | | +----´ `----+ +----´ `----+ | | | | landscape > CONN | | +----. .----+ vFlip | portrait | | bk | | bl | | | `----'-----------'----´ | | | | +----. ,----+ |<------ hFlip ------>| v | bk | | bl | (mirrored) --- `----'-vv-'----´ (upside down) CONN .---------. .-----. |bl bk| |bl bk| | | < (over head) > | | |gn rd| |gn rd| `---------´ `-----´ Signed-off-by: Stephan Linz <[email protected]>
To improve the clarity of the main page, almost all subsections with detailed information are moved to newly created RST include files in the respective subdirectories. Signed-off-by: Stephan Linz <[email protected]>
- Waveshare RP2040 LCD 0.96 - Waveshare RP2040 Geek Signed-off-by: Stephan Linz <[email protected]>
All supported displays now provide standardized variations for the orientation of the content. The displays always have a preferred orientation, landscape, with the USB port on the left side. Alternatively, this orientation can be changed to portrait and the following variations can also be applied: - mirrored (flip horizontal, hFlip) - upside down (flip vertical, vFlip) - over head (rotated by 180°) USBD --- .----.-^^-.----. .----.-----------.----. ^ | rd | | gn | | rd | | gn | | +----´ `----+ +----´ `----+ | | | USBD < landscape | | | +----. .----+ vFlip | portrait | | bk | | bl | | | `----'-----------'----´ | | | | +----. ,----+ |<------ hFlip ------>| v | bk | | bl | (mirrored) --- `----'----'----´ (upside down) .---------. .-----. |bl bk| |bl bk| | | < (over head) > | | |gn rd| |gn rd| `---------´ `-----´ Signed-off-by: Stephan Linz <[email protected]>
Enhancement of the documentation to include the newer Waveshare RP2040-LCD-0.96 Rev 2.0 PCB. The illustrations of the older PCB revision also had to be updated. These were incorrect. Signed-off-by: Stephan Linz <[email protected]>
Add new Raspberry Pi Pico LCD Shields: - Pico LCD 0.96 shield by Waveshare - Pico LCD 1.3 shield by Waveshare - Pico LCD 1.44 shield by Waveshare - Pico LCD 1.8 shield by Waveshare - Pico ResTouch LCD 2.8 shield by Waveshare Signed-off-by: Stephan Linz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Fixes #233 and also brings many improvements in shield documentation: