Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Node 12 version #6

Closed
wants to merge 2 commits into from
Closed

Node 12 version #6

wants to merge 2 commits into from

Conversation

yoprogramo
Copy link

To generate image with node 12 (latest LTS)

@alecgerona
Copy link

Can we get this merged @tiangolo? 🙏

Copy link

@dev-124 dev-124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@tiangolo
Copy link
Owner

Thanks all for the comments! And sorry for the long delay. 🙈

I no longer use nor recommend this Docker image, I think you are much better off building a Docker image yourself, so I updated all the docs to explain how to do it: https://github.com/tiangolo/node-frontend

The only extra step is creating and copying a simple nginx.conf file that you can copy-paste.

Given that, I'll now close this one. But thanks for the interest! ☕

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants