Changed createPendingIntent() from FLAG_IMMUTABLE to FLAG_MUTABLE #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_IMMUTABLE to FLAG_MUTABLE
|
Thank you for the PR. Will test it 👍 Test version: We can merge #71 afterwards so it will be version 5.1.0 at the end |
|
Can we move this PR to master? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The createPendingIntent() in NfcForegroundDispatchFilter's with FLAG_IMMUTABLE was causing the event.intent action and type to be null while reading NDEF tags with Titanium SDK 12.1.2.GA with ForegroundDispatch. Changing this to FLAG_MUTABLE seemed to resolve the problem. I based this change on the solution found here: https://stackoverflow.com/questions/76655730/why-nfc-works-with-pendingintent-flag-mutable-and-not-with-pendingintent-flag-im