POC: replace facet_grid(switch)
with strip.position
#6161
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #5999.
Briefly, it deprecates
facet_grid(switch)
in favour offacet_grid(strip.position = "top"/"bottom"/"left"/"right")
.If one of the directions is omitted (top/bottom in example below), the default will be filled in:
However, when specifying >1 position in the same direction, this taken literally.
Created on 2024-10-25 with reprex v2.1.1
It is currently a POC because I'm unsure of whether we should do this. Reverse dependency checks revealed a lot of facet extensions that are rather sensitive to parameters in
facet_grid()
/facet_wrap()
when implementing #5855. For this reason, I expect some revdep troubles with this PR. In contrast to #5855, which adds new functionality, this PR is mostly 'cosmetic'.