Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] format numbers and dates (range_format_pattern) #200

Closed
wants to merge 5 commits into from

Conversation

mattle24
Copy link

Proposed as fixes #81, partially fixes #179 .

New range_format_pattern() to be able to format date and number data in Sheets.

@jennybc we talked about this a few months ago in #81, please let me know what you think of this, even if it's just this is not the path forward for googlesheets4! I did try an approach to formatting using vctrs (mattle24#1), but I found it to be less flexible for supporting both numbers and dates, since the types are separate in R but similar in Google Sheets. Also, I think that formatting directly on the Google Sheet, rather than manipulating the R data frame, could make it easier to add more formatting (color, alignment, etc.) down the road.

Thanks for the work on the package, it's really useful!

@jennybc
Copy link
Member

jennybc commented Nov 26, 2020

Thanks for exploring this @mattle24. As we discussed elsewhere, I doubt this will get merged.

But a concrete PR definitely helps everyone pre-think about what this feature should look like, it shows exactly what you have in mind, etc. So it will accelerate progress on getting this sort of functionality, which is in the plan.

@mattle24
Copy link
Author

mattle24 commented Dec 1, 2020

Sounds great, thanks @jennybc !

@mattle24 mattle24 closed this Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to change cell formats inside an existing googlesheet Formats when writing date/time/datetime
2 participants