Improve classical decomposition's season_adjust aliases

tidyverts · Nov 11, 2023 · 2823121 · 2823121
1 parent 1ad4cfd
commit 2823121
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 7 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,10 @@
 # feasts (development version)
 
+## Bug fixes
+
+* Changed the metadata of classical decomposition's components to better reflect
+  the seasonally adjusted variable's structure.
+
 # feasts 0.3.1
 
 Minor patch to resolve CRAN check issues with S3 method consistency.

diff --git a/R/classical.R b/R/classical.R
@@ -23,16 +23,14 @@ train_classical <- function(.data, formula, specials,
   dcmp_op <- switch(type,
                     additive = "+",
                     multiplicative = "*")
-  dcmp_op_inv <- switch(type,
-                        additive = "-",
-                        multiplicative = "/")
+  cl_sadj <- call2(dcmp_op, sym("trend"), sym("random"))
 
   dcmp <- decompose(ts(y, frequency = m), type = type, ...)[c("trend", "seasonal", "random")]
 
   dcmp <- .data %>%
     mutate(
       !!!map(dcmp, as.numeric),
-      season_adjust = !!call2(dcmp_op_inv, sym(resp), sym("seasonal"))
+      season_adjust = !!cl_sadj
     )
 
   seasonalities <- list(
@@ -42,7 +40,7 @@ train_classical <- function(.data, formula, specials,
   aliases <- list2(
     !!resp := reduce(syms(c("trend", "seasonal", "random")),
                      function(x,y) call2(dcmp_op, x, y)),
-    season_adjust = call2(dcmp_op_inv, sym(resp), sym("seasonal"))
+    season_adjust = cl_sadj
   )
 
   structure(

diff --git a/man/generate.stl_decomposition.Rd b/man/generate.stl_decomposition.Rd