[For Reference] Example of adding a new API and Controller #3587
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an example PR to show rougly the changes necessary to add the skeleton for a new API and Controller.
NOTE
--namespaced=false
on step 1.The commits are broken down and show precisely which commands were run.
Specifically:
Generate the new Resource and controller skeleton
Generate manifests
Add a new Reconciler to
pkg/controller
, and point theinternal/controller
implementation at it.The next steps here would be to fill out the
Add
andReconcile
functions inpkg/controller/demoresource/demoresource_controller.go
with the specific logic of the new feature.For PR author
make gen-files
make gen-versions
For PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bug
if this is a bugfix.kind/enhancement
if this is a a new feature.enterprise
if this PR applies to Calico Enterprise only.