Ensure CRDs are created on boot #3610
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
coutinhop
reviewed
Nov 22, 2024
| @@ -345,6 +345,15 @@ func main() { | |||
| } | |||
| setupLog.WithValues("provider", provider).Info("Checking type of cluster") | |||
|
|
|||
| // If configured to managed CRDs, do a preliminary install of them here. The Installation controller | |||
There was a problem hiding this comment.
Suggested change
| // If configured to managed CRDs, do a preliminary install of them here. The Installation controller | |
| // If configured to manage CRDs, do a preliminary install of them here. The Installation controller |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make sure CRDs exist early in bootup, as we require these CRDs to be present in order to launch controllers.
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.