Fixed on fetching from xiami #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified in the src of SONG and ARTIST of xiami in ol_lrc_fetch_xiami.c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As metioned in the Issue of OriginRepo:
'It can not fetch lyrics?! #3'
warmsun0220 said:
the URL of xiami had changed，try to open the file ol_lrc_fetch_xiami.c and change the *TITLE_PATTERN to "href=\"http://www.xiami.com/song/" and recompilation itAfter that, it can fetch the title from xiamia, but the lyric file downloaded contains just an 'HTTP403' page.
modify
ARTIST_PATTERNmakes it works.Modified in the src of
TITLE_PATTERNandARTIST_PATTERNof xiami inol_lrc_fetch_xiami.c